WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
159445
AX: Use UNLIKELY around AXObjectCache::accessibilityEnabled()
https://bugs.webkit.org/show_bug.cgi?id=159445
Summary
AX: Use UNLIKELY around AXObjectCache::accessibilityEnabled()
chris fleizach
Reported
2016-07-05 17:22:29 PDT
This is being done in some places, we could do it in more
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-07-05 17:22:51 PDT
<
rdar://problem/27185997
>
Joanmarie Diggs
Comment 2
2016-07-05 17:54:22 PDT
Related to this: There are a number of places in WebCore, but outside of the accessibility code, in which Document::existingAXObjectCache() is called without first checking AXObjectCache::accessibilityEnabled(). If the checks that are present (e.g. in RenderBlockLineLayout.cpp, RenderImage.cpp) are indeed worth doing, they are potentially also worth doing in RenderBlock.cpp and RenderWidget.cpp, and RenderText.cpp, and RenderMenuList.cpp, and .... Or we could instead just add a single: if (UNLIKELY(AXObjectCache::accessibilityEnabled())) to Document::existingAXObjectCache().
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug