Bug 159429 - InlineAccess::sizeForLengthAccess() is wrong on some platforms because it should also consider "length" not being array length
Summary: InlineAccess::sizeForLengthAccess() is wrong on some platforms because it sho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-05 11:37 PDT by Saam Barati
Modified: 2016-07-06 11:24 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2016-07-05 12:40 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
patch for landing (2.56 KB, patch)
2016-07-05 13:00 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (2.80 KB, patch)
2016-07-05 15:25 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-07-05 11:37:04 PDT 
...
Comment 1 Saam Barati 2016-07-05 12:40:41 PDT 
Created attachment 282806 [details]
Patch
Comment 2 Saam Barati 2016-07-05 13:00:37 PDT 
Created attachment 282810 [details]
patch for landing
Comment 3 Saam Barati 2016-07-05 15:19:31 PDT 
I guess GCC can't compute std::max() of two constexpr things inside another constexpr.
I'll move these functions to be normal inlined functions.
Comment 4 Saam Barati 2016-07-05 15:25:26 PDT 
Created attachment 282815 [details]
patch for landing
Comment 5 Csaba Osztrogonác 2016-07-06 01:53:59 PDT 
Comment on attachment 282815 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=282815&action=review

> Source/JavaScriptCore/bytecode/InlineAccess.h:64
> +    // This is the maximum between inline and out of line propery replace cases.

typo: proper_t_y
Comment 6 Saam Barati 2016-07-06 11:24:33 PDT 
landed with typo fix in:
https://trac.webkit.org/changeset/202866