Bug 159413 – Remove ClientCredentialPolicy cross-origin option from ResourceLoaderOptions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

It is probably redundant with FetchOptions::Credentials

[youenn fablet]

Created attachment 282769 [details]
Patch

[youenn fablet]

Some options in Mac-specific AV loader code seems a bit odd: stored credentials are not allowed, credential mode is omit but credential request is ask-if-same-origin (see Source/WebCore/platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp and Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm).
I changed that to not-ask-for-any-credentials.

[Build Bot]

Comment on attachment 282769 [details]
Patch

Attachment 282769 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1629716

New failing tests:
imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic.html

[Build Bot]

Created attachment 282773 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282769 [details]
Patch

Attachment 282769 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1629721

New failing tests:
imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic.html

[Build Bot]

Created attachment 282774 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282769 [details]
Patch

Attachment 282769 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1629731

New failing tests:
imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic.html

[Build Bot]

Created attachment 282775 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282769 [details]
Patch

Attachment 282769 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1629733

New failing tests:
imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic.html

[Build Bot]

Created attachment 282776 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[youenn fablet]

Created attachment 282782 [details]
Rebasing test

[youenn fablet]

Created attachment 282784 [details]
Removing WK1 expectation

[youenn fablet]

Created attachment 284196 [details]
Rebasing

[Build Bot]

Comment on attachment 284196 [details]
Rebasing

Attachment 284196 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1722575

New failing tests:
imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic.html

[Build Bot]

Created attachment 284198 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 284196 [details]
Rebasing

Attachment 284196 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1722581

New failing tests:
imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic.html

[Build Bot]

Created attachment 284199 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[youenn fablet]

Created attachment 284202 [details]
Fixed test

[Alex Christensen]

Comment on attachment 284202 [details]
Fixed test

View in context: https://bugs.webkit.org/attachment.cgi?id=284202&action=review

> Source/WebCore/ChangeLog:14
> +        Since DocumentThreadableLoader is already computing whether the request is cross-origin, it can also computes

computes -> compute

> Source/WebCore/loader/ResourceLoaderOptions.h:139
> +    ClientCredentialPolicy clientCredentialPolicy { ClientCredentialPolicy::CannotAskClientForCredentials };

This adds 6 bits to the size of ResourceLoaderOptions unnecessarily.  Can we still keep it small?

> LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic-expected.txt:-1
> -http://localhost:8800/fetch/api/resources/authentication.py?realm=test - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet

I don't think this part applies to trunk any more.

[youenn fablet]

Created attachment 284594 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

> > Source/WebCore/ChangeLog:14
> > +        Since DocumentThreadableLoader is already computing whether the request is cross-origin, it can also computes
> 
> computes -> compute

OK

> > Source/WebCore/loader/ResourceLoaderOptions.h:139
> > +    ClientCredentialPolicy clientCredentialPolicy { ClientCredentialPolicy::CannotAskClientForCredentials };
> 
> This adds 6 bits to the size of ResourceLoaderOptions unnecessarily.  Can we
> still keep it small?

I removed uint8_t for the enum class.
Do you know why other enumerations are using it?

> > LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic-expected.txt:-1
> > -http://localhost:8800/fetch/api/resources/authentication.py?realm=test - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
> 
> I don't think this part applies to trunk any more.

Indeed :)

[WebKit Commit Bot]

Comment on attachment 284594 [details]
Patch for landing

Clearing flags on attachment: 284594

Committed r203720: <http://trac.webkit.org/changeset/203720>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.