Bug 159407 – [EFL] Remove mac configuration dependency in WebKit Version definition

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

EFL port has been used Version.xconfig file in WebKit/mac/Configurations in order to generate WebKitVersion.h file. But it can be simply defined in cmake as GTK port. Let's remove the mac dependency !

[Gyuyoung Kim]

Created attachment 282720 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 282720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282720&action=review

r=me with one question.

> Source/WebCore/PlatformEfl.cmake:-262
> -

Is it OK not to keep the version in sync with Mac ports?
Personally, I think it's OK, since GTK port already does the same thing and EFL port can have its own user agent number.

[Gyuyoung Kim]

(In reply to comment #2)
> Comment on attachment 282720 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282720&action=review
> 
> r=me with one question.
> 
> > Source/WebCore/PlatformEfl.cmake:-262
> > -
> 
> Is it OK not to keep the version in sync with Mac ports?
> Personally, I think it's OK, since GTK port already does the same thing and
> EFL port can have its own user agent number.

I plan to be in sync with mac port version manually whenever EFLWebKit is released. Anyway I think EFL port doesn't need to have mac port dependency when building EFL port. Thanks review !

[WebKit Commit Bot]

Comment on attachment 282720 [details]
Patch

Clearing flags on attachment: 282720

Committed r202813: <http://trac.webkit.org/changeset/202813>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.