Bug 159407 - [EFL] Remove mac configuration dependency in WebKit Version definition
Summary: [EFL] Remove mac configuration dependency in WebKit Version definition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-04 07:53 PDT by Gyuyoung Kim
Modified: 2016-07-04 23:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.25 KB, patch)
2016-07-04 07:54 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-07-04 07:53:07 PDT
EFL port has been used Version.xconfig file in WebKit/mac/Configurations in order to generate WebKitVersion.h file. But it can be simply defined in cmake as GTK port. Let's remove the mac dependency !
Comment 1 Gyuyoung Kim 2016-07-04 07:54:36 PDT
Created attachment 282720 [details]
Patch
Comment 2 Yusuke Suzuki 2016-07-04 23:01:22 PDT
Comment on attachment 282720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282720&action=review

r=me with one question.

> Source/WebCore/PlatformEfl.cmake:-262
> -

Is it OK not to keep the version in sync with Mac ports?
Personally, I think it's OK, since GTK port already does the same thing and EFL port can have its own user agent number.
Comment 3 Gyuyoung Kim 2016-07-04 23:14:47 PDT
(In reply to comment #2)
> Comment on attachment 282720 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282720&action=review
> 
> r=me with one question.
> 
> > Source/WebCore/PlatformEfl.cmake:-262
> > -
> 
> Is it OK not to keep the version in sync with Mac ports?
> Personally, I think it's OK, since GTK port already does the same thing and
> EFL port can have its own user agent number.

I plan to be in sync with mac port version manually whenever EFLWebKit is released. Anyway I think EFL port doesn't need to have mac port dependency when building EFL port. Thanks review !
Comment 4 WebKit Commit Bot 2016-07-04 23:36:15 PDT
Comment on attachment 282720 [details]
Patch

Clearing flags on attachment: 282720

Committed r202813: <http://trac.webkit.org/changeset/202813>
Comment 5 WebKit Commit Bot 2016-07-04 23:36:19 PDT
All reviewed patches have been landed.  Closing bug.