Bug 159404 - Remove CredentialRequest ResourceLoaderOptions
Summary: Remove CredentialRequest ResourceLoaderOptions
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Depends on:
Blocks: 151937
  Show dependency treegraph
Reported: 2016-07-04 04:15 PDT by youenn fablet
Modified: 2016-07-05 00:59 PDT (History)
3 users (show)

See Also:

Patch (25.10 KB, patch)
2016-07-04 04:44 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (26.35 KB, patch)
2016-07-05 00:30 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-07-04 04:15:36 PDT
CredentialRequest is only used by DocumentThreadableLoader to disable credential sending in case of cross-origin redirection.
This is handled by FetchOptions::Credentials::SameOrigin.
Comment 1 youenn fablet 2016-07-04 04:16:37 PDT
Note that ultimately, all credential-related ResourceLoaderOptions should probably be removed except for FetchOptions::Credentials.
Comment 2 youenn fablet 2016-07-04 04:44:09 PDT
Created attachment 282706 [details]
Comment 3 youenn fablet 2016-07-05 00:30:48 PDT
Created attachment 282754 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-07-05 00:59:53 PDT
Comment on attachment 282754 [details]
Patch for landing

Clearing flags on attachment: 282754

Committed r202815: <http://trac.webkit.org/changeset/202815>
Comment 5 WebKit Commit Bot 2016-07-05 00:59:57 PDT
All reviewed patches have been landed.  Closing bug.