Bug 159395 - Rename run-webkit-httpd to run-webkit-test-servers
Summary: Rename run-webkit-httpd to run-webkit-test-servers
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-03 23:31 PDT by youenn fablet
Modified: 2016-07-19 00:57 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.58 KB, patch)
2016-07-03 23:33 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-07-03 23:31:17 PDT
This script is not only launching https but also web socket and web-platform-test servers
Comment 1 youenn fablet 2016-07-03 23:33:58 PDT
Created attachment 282682 [details]
Patch
Comment 2 youenn fablet 2016-07-03 23:34:49 PDT
Follow-up to bug 152486
Comment 3 Alex Christensen 2016-07-04 00:50:14 PDT
Comment on attachment 282682 [details]
Patch

Is this really necessary?  This makes tab completion even worse.  If it's renamed, I think it should be a different name.  Right now I have Tools/Scripts in my PATH, so when I want to run-webkit-tests, I just type run-w<tab>-t<tab>.  This would make that slower.
Comment 4 youenn fablet 2016-07-04 00:53:22 PDT
Would run-test-servers work?
It only tab-conflicts with run-test-runner.
Comment 5 Daniel Bates 2016-07-04 07:40:00 PDT
I do not feel that the name of the script, run-webkit-httpd, is ambiguous enough to necessitate a rename. Although it could be claimed that the name of this script is a bit disingenuous with respect to starting a web socket socket (Web Socket does use HTTP for its handshake), I do not feel that this script is ambiguous with respect to starting the web platform test server as the web platform test server is an HTTP server. And I do not feel that the name of this script is disingenuous enough in the Web Socket case to necessitate a rename.

With respect to starting the web platform test server, any confusion is likely from the script's historic lack of support for starting the web platform test server. Following the fix for bug #152486, run-webkit-httpd supports starting the web platform test server. We should consider announcing such support on webkit-dev. This announcement may lead to feedback about the name of the script run-webkit-httpd.
Comment 6 youenn fablet 2016-07-04 07:57:14 PDT
I'll send a mail.

To be noted that there are also run-webkit-websocketserver, new-run-webkit-httpd and new-run-webkit-websocketserver scripts.

It might be good to remove some of them.
Comment 7 Ryosuke Niwa 2016-07-04 12:47:40 PDT
I don't like the new name "run-webkit-test-servers" because "test severs" don't tell me what kind of server it is given there's also web socket server, etc... If anything, I'd call it run-webkit-test-httpd-servers but that might be too long.  I think the status quo: run-webkit-httpd is good enough.
Comment 8 youenn fablet 2016-07-19 00:57:42 PDT
I also spotted Tools/Scripts/webkitperl/httpd.pm.
Is it used somewhere?