Bug 159392 - [Xcode] With default verbosity, make(1) output no longer hides environment variable listings
Summary: [Xcode] With default verbosity, make(1) output no longer hides environment va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-03 21:24 PDT by mitz
Modified: 2016-07-03 23:00 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.11 KB, patch)
2016-07-03 21:27 PDT, mitz
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-07-03 21:24:53 PDT
A long time ago, Makefile.shared was set up to filter out the environment variable listings preceding script build phase output by default by piping the output through "grep -v setenv". In version 6, Xcode switched from using “setenv” to using “export” for those listings, so the filtering stopped working. In Xcode 7, xcodebuild has a -hideShellScriptEnvironment option that suppresses the listings so they don’t need to be filtered out.
Comment 1 mitz 2016-07-03 21:27:17 PDT
Created attachment 282675 [details]
Patch
Comment 2 mitz 2016-07-03 23:00:08 PDT
Fixed in <http://trac.webkit.org/r202798>.