Bug 159389 - FTL should refer to B3 types directly
Summary: FTL should refer to B3 types directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-03 10:59 PDT by Filip Pizlo
Modified: 2016-07-03 12:37 PDT (History)
11 users (show)

See Also:


Attachments
the patch (71.60 KB, patch)
2016-07-03 11:01 PDT, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff
the patch (72.15 KB, patch)
2016-07-03 11:55 PDT, Filip Pizlo
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-07-03 10:59:04 PDT
We should say Int32 instead of m_out.int32, for example.
Comment 1 Filip Pizlo 2016-07-03 11:01:47 PDT
Created attachment 282662 [details]
the patch
Comment 2 WebKit Commit Bot 2016-07-03 11:04:45 PDT
Attachment 282662 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1871:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1871:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:3768:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2016-07-03 11:39:03 PDT
Comment on attachment 282662 [details]
the patch

r=me
Comment 4 Filip Pizlo 2016-07-03 11:55:43 PDT
Created attachment 282664 [details]
the patch
Comment 5 Filip Pizlo 2016-07-03 11:56:32 PDT
Comment on attachment 282664 [details]
the patch

Reviewed by Saam.  The only change in this patch is a fix for the debug build.
Comment 6 WebKit Commit Bot 2016-07-03 11:58:45 PDT
Attachment 282664 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1871:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:1871:  Wrong number of spaces before statement. (expected: 24)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:3768:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Filip Pizlo 2016-07-03 12:37:08 PDT
Landed in r202792