RESOLVED FIXED 159386
[win] Update TestExpectations after the MathML refactoring 
https://bugs.webkit.org/show_bug.cgi?id=159386
Summary [win] Update TestExpectations after the MathML refactoring
Frédéric Wang (:fredw)
Reported 2016-07-02 01:54:50 PDT
I just landed https://trac.webkit.org/changeset/202776 to essentially update pixel tests. I'd like to update the following rules too from 2015, although I can not see the results on the bots. * [ Debug ] mathml/roots-removeChild.html [ ImageOnlyFailure ] => Probably fixed by 153987? * mathml/presentation/style-changed.html [ Crash Pass ] => I don't see any crash on the flakiness dashboard. Probably fixed by the MathML refactoring, given that we are more careful with style change. * mathml/opentype/munderover-layout-resize.html => Per discussion on bug 140522, there seemed to be an issue with the management of GlyphData. Hopefully we are more careful with that in MathOperator. * mathml/opentype/opentype-stretchy-horizontal.html => Same here, I guess. * mathml/presentation/mo-invisible.html => RenderMathMLOperator::computePreferredLogicalWidths checks whether GlyphData is valid before deferencing it.
Attachments
Patch (2.39 KB, patch)
2016-07-02 01:56 PDT, Frédéric Wang (:fredw) 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-07-02 01:56:41 PDT
Created attachment 282640 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2016-07-03 09:27:45 PDT
Committed r202788: <http://trac.webkit.org/changeset/202788>
Frédéric Wang (:fredw)
Comment 3 2016-07-03 13:04:38 PDT
For the record, I reverted the change for mathml/presentation/style-changed.html as it still seems to be crashing. Other tests don't seem to crash anymore in this first run. https://trac.webkit.org/changeset/202794
Note You need to log in before you can comment on or make changes to this bug.