Bug 159386 - [win] Update TestExpectations after the MathML refactoring
Summary: [win] Update TestExpectations after the MathML refactoring
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
Depends on:
Blocks: 140522 140653
  Show dependency treegraph
Reported: 2016-07-02 01:54 PDT by Frédéric Wang (:fredw)
Modified: 2016-07-03 13:04 PDT (History)
1 user (show)

See Also:

Patch (2.39 KB, patch)
2016-07-02 01:56 PDT, Frédéric Wang (:fredw)
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-07-02 01:54:50 PDT
I just landed https://trac.webkit.org/changeset/202776 to essentially update pixel tests.

I'd like to update the following rules too from 2015, although I can not see the results on the bots. 

* [ Debug ] mathml/roots-removeChild.html [ ImageOnlyFailure ] => Probably fixed by 153987?
* mathml/presentation/style-changed.html [ Crash Pass ] => I don't see any crash on the flakiness dashboard. Probably fixed by the MathML refactoring, given that we are more careful with style change.
* mathml/opentype/munderover-layout-resize.html => Per discussion on bug 140522, there seemed to be an issue with the management of GlyphData. Hopefully we are more careful with that in MathOperator.
* mathml/opentype/opentype-stretchy-horizontal.html => Same here, I guess.
* mathml/presentation/mo-invisible.html => RenderMathMLOperator::computePreferredLogicalWidths checks whether GlyphData is valid before deferencing it.
Comment 1 Frédéric Wang (:fredw) 2016-07-02 01:56:41 PDT
Created attachment 282640 [details]
Comment 2 Frédéric Wang (:fredw) 2016-07-03 09:27:45 PDT
Committed r202788: <http://trac.webkit.org/changeset/202788>
Comment 3 Frédéric Wang (:fredw) 2016-07-03 13:04:38 PDT
For the record, I reverted the change for mathml/presentation/style-changed.html as it still seems to be crashing. Other tests don't seem to crash anymore in this first run.