Bug 159383 – [RTL Scrollbars] RTL Scrollbars broken with clients creating Web Views via [WKView initWithFrame:contextRef:pageGroupRef:]

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[RTL Scrollbars] RTL Scrollbars broken with clients creating Web Views via [WKView initWithFrame:contextRef:pageGroupRef:]

[Myles C. Maxfield]

Created attachment 282633 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/26921117>

[Anders Carlsson]

Comment on attachment 282633 [details]
Patch

I think this is going to break the case where you have the policy set on the preferences?

[Myles C. Maxfield]

(In reply to comment #3)
> Comment on attachment 282633 [details]
> Patch
> 
> I think this is going to break the case where you have the policy set on the
> preferences?

There are two bits:
Whether the policy is .Content or .System
Whether or not the system is in RTL

This patch only sets the second bit. The second bit is only consulted if the policy is .System.

[Anders Carlsson]

Comment on attachment 282633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282633&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:992
> +static uint32_t convertSystemLayoutDirection(NSUserInterfaceLayoutDirection direction)

I'd change this to return the WebCore::UserInterfaceLayoutDirection and then to the uint32_t cast at the call site.

[Myles C. Maxfield]

Created attachment 282919 [details]
Patch

[Anders Carlsson]

Comment on attachment 282919 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282919&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:992
> +static WebCore::UserInterfaceLayoutDirection convertSystemLayoutDirection(NSUserInterfaceLayoutDirection direction)

I would call this toUserInterfaceLayoutDirection - I think we use that idiom in other places.

[Myles C. Maxfield]

Created attachment 282922 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 282922 [details]
Patch for committing

Rejecting attachment 282922 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 282922, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit2/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/1637210

[Myles C. Maxfield]

Committed r202878: <http://trac.webkit.org/changeset/202878>