Bug 159378 - [Cocoa] Adopt modern API availability macros
Summary: [Cocoa] Adopt modern API availability macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-01 17:45 PDT by mitz
Modified: 2017-03-25 19:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch for EWS (126.29 KB, patch)
2016-07-01 17:46 PDT, mitz 		no flags Details | Formatted Diff | Diff
Patch for EWS (127.14 KB, patch)
2016-07-01 18:00 PDT, mitz 		no flags Details | Formatted Diff | Diff
Patch for EWS (127.14 KB, patch)
2016-07-02 23:30 PDT, mitz 		no flags Details | Formatted Diff | Diff
Patch for EWS (127.14 KB, patch)
2016-07-03 00:12 PDT, mitz 		no flags Details | Formatted Diff | Diff
Patch for EWS (127.00 KB, patch)
2016-07-03 08:51 PDT, mitz 		no flags Details | Formatted Diff | Diff
Use modern availability macros (134.94 KB, patch)
2016-07-03 10:00 PDT, mitz 		sam: review+
Details | Formatted Diff | Diff
Add TARGET_OS_* guards (5.61 KB, patch)
2016-07-03 11:52 PDT, mitz 		sam: review+
Details | Formatted Diff | Diff
Another one for EWS (6.50 KB, patch)
2016-07-03 12:13 PDT, mitz 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-07-01 17:45:44 PDT 
Adopt the API_AVAILABLE family of macros from macOS Sierra and iOS 10’s CFAvailability.h.
Comment 1 mitz 2016-07-01 17:46:47 PDT 
Created attachment 282618 [details]
Patch for EWS
Comment 2 mitz 2016-07-01 18:00:50 PDT 
Created attachment 282621 [details]
Patch for EWS
Comment 3 mitz 2016-07-02 23:30:01 PDT 
Created attachment 282654 [details]
Patch for EWS
Comment 4 mitz 2016-07-03 00:12:51 PDT 
Created attachment 282655 [details]
Patch for EWS
Comment 5 mitz 2016-07-03 08:51:32 PDT 
Created attachment 282658 [details]
Patch for EWS
Comment 6 mitz 2016-07-03 10:00:15 PDT 
Created attachment 282660 [details]
Use modern availability macros
Comment 7 mitz 2016-07-03 10:09:06 PDT 
Committed <http://trac.webkit.org/r202789>.
Comment 8 mitz 2016-07-03 11:33:21 PDT 
Reopening since removing the NA annotations made things available on those platforms.
Comment 9 mitz 2016-07-03 11:52:00 PDT 
Created attachment 282663 [details]
Add TARGET_OS_* guards
Comment 10 WebKit Commit Bot 2016-07-03 11:53:56 PDT 
Attachment 282663 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 mitz 2016-07-03 12:13:03 PDT 
Created attachment 282666 [details]
Another one for EWS
Comment 12 WebKit Commit Bot 2016-07-03 12:15:24 PDT 
Attachment 282666 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 mitz 2016-07-03 12:45:09 PDT 
Committed <http://trac.webkit.org/r202793>.