Bug 159375 – REGRESSION(r189668): Notification tests are flakey

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

REGRESSION(r189668): Notification tests are flakey

[Myles C. Maxfield]

Created attachment 282595 [details]
Patch

[Myles C. Maxfield]

*** Bug 159374 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

Are bug 150736 and bug 149218 same as this one?

[Myles C. Maxfield]

(In reply to comment #3)
> Are bug 150736 and bug 149218 same as this one?

Yep.

[Myles C. Maxfield]

*** Bug 150736 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

Comment on attachment 282595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282595&action=review

> Source/WebKit2/ChangeLog:13
> +        * UIProcess/API/C/WKNotificationManagerPrivate.h: Copied from Tools/WebKitTestRunner/WebNotificationProvider.h.

This should be WKNotificationManagerInternal.h, because it's only supposed to be used internally by WebKit tools, not as an SPI.

> Source/WebKit2/UIProcess/API/C/WKNotificationManagerPrivate.h:2
> + * Copyright (C) 2011 Apple Inc. All rights reserved.

2016

> Source/WebKit2/UIProcess/API/C/WKNotificationManagerPrivate.h:35
> +WK_EXPORT uint64_t WKNotificationManagerGetLocalID(WKNotificationManagerRef manager, WKNotificationRef notification);

May be good to have "ForTesting" in the name here too. Or just put into the regular WKNotificationManager.h with such a name - I'd ask Sam about what he prefers.

> Tools/ChangeLog:18
> +        The solution is for WebNotificationProvider, imlemented in WebKitTestRunner in the UI Process, to

imPlemented

> LayoutTests/platform/mac/TestExpectations:-1261
> -webkit.org/b/149218 http/tests/notifications/events.html [ Pass Crash ]

Was this the only test marked as a flaky crash? I expect that the other one from my comment should have been marked too.

> ChangeLog:9
> +        * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

?

[Myles C. Maxfield]

Created attachment 282620 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 282623 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 282624 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 282624 [details]
Patch for committing

Clearing flags on attachment: 282624

Committed r202772: <http://trac.webkit.org/changeset/202772>

[David Kilzer (:ddkilzer)]

<rdar://problem/22760990>