Bug 159368 - Web Inspector: CallFrame console.assert seen in tests (sourceCodeLocation instanceof SourceCodeLocation)
Summary: Web Inspector: CallFrame console.assert seen in tests (sourceCodeLocation ins...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-07-01 13:58 PDT by Joseph Pecoraro
Modified: 2016-07-02 20:36 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.39 KB, patch)
2016-07-01 13:59 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-07-01 13:58:30 PDT 
Summary:
CallFrame console.assert seen in tests (sourceCodeLocation instanceof SourceCodeLocation)

file:///Users/pecoraro/Build/Debug/WebInspectorUI.framework/Resources/TestCombined.js:10761:23: CONSOLE ERROR

> WebInspector.CallFrame = class CallFrame extends WebInspector.Object
> {
>     constructor(id, sourceCodeLocation, functionName, thisObject, scopeChain, nativeCode, programCode, isTailDeleted)
>     {
>         super();
> 
>         console.assert(!sourceCodeLocation || sourceCodeLocation instanceof WebInspector.SourceCodeLocation);


Turns out the sourceCodeLocation is an instanceof WebInspector.LazySourceCodeLocation which is a subclass of WebInspector.SourceCodeLocation.

However, SourceCodeLocation is defined again AFTER SourceCodeLocation+LazySourceCodeLocation were setup...
Comment 1 Joseph Pecoraro 2016-07-01 13:59:46 PDT 
Created attachment 282574 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-07-02 20:36:39 PDT 
Comment on attachment 282574 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 282574

Committed r202785: <http://trac.webkit.org/changeset/202785>
Comment 3 WebKit Commit Bot 2016-07-02 20:36:42 PDT 
All reviewed patches have been landed.  Closing bug.