Bug 159365 – REGRESSION (r202641): Netflix playback stalls after a few seconds

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

REGRESSION (r202641): Netflix playback stalls after a few seconds

[Jer Noble]

Created attachment 282591 [details]
Patch

[Build Bot]

Comment on attachment 282591 [details]
Patch

Attachment 282591 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1609442

New failing tests:
http/tests/media/media-source/mediasource-play.html
http/tests/media/media-source/mediasource-remove.html
media/media-source/media-source-remove.html

[Build Bot]

Created attachment 282602 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Comment on attachment 282591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282591&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:666
> +    PlatformTimeRanges erasedRanges;

The elf bot's WTFMove macro doesn't like you returning this.

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1617
> +        // disjoint ranges separated by less than a "fudge factor"

Nit: no period at the end of the sentence.

[Build Bot]

Comment on attachment 282591 [details]
Patch

Attachment 282591 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1609474

New failing tests:
http/tests/media/media-source/mediasource-play.html
http/tests/media/media-source/mediasource-remove.html
media/media-source/media-source-remove.html

[Build Bot]

Created attachment 282605 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282591 [details]
Patch

Attachment 282591 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1609473

New failing tests:
http/tests/media/media-source/mediasource-play.html
http/tests/media/media-source/mediasource-remove.html
media/media-source/media-source-remove.html

[Build Bot]

Created attachment 282606 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Jer Noble]

Created attachment 282619 [details]
Patch

[Jer Noble]

Created attachment 282807 [details]
Patch

[Eric Carlson]

Comment on attachment 282807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282807&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1617
> +        // Eliminate small gaps between buffered ranges by coalescing
> +        // disjoint ranges separated by less than a "fudge factor"

Nit: this sentence needs a period.

[Jer Noble]

Committed r202829: <http://trac.webkit.org/changeset/202829>