Bug 159349 - [Win] DLLs are missing version information.
Summary: [Win] DLLs are missing version information.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on: 159568
Blocks:
  Show dependency tree / graph
 
Reported: 2016-07-01 06:19 PDT by Per Arne Vollan
Modified: 2016-07-13 10:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.94 KB, patch)
2016-07-01 06:53 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (5.47 KB, patch)
2016-07-11 07:01 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (6.82 KB, patch)
2016-07-11 10:31 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2016-07-13 07:03 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (3.17 KB, patch)
2016-07-13 08:07 PDT, Per Arne Vollan 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-07-01 06:19:42 PDT 
We need to run the perl version stamp utility.
Comment 1 Per Arne Vollan 2016-07-01 06:26:04 PDT 
<rdar://problem/26358998>
Comment 2 Per Arne Vollan 2016-07-01 06:53:00 PDT 
Created attachment 282545 [details]
Patch
Comment 3 Brent Fulgham 2016-07-01 09:34:53 PDT 
Comment on attachment 282545 [details]
Patch

Oh, excellent! Thank you. r=me.
Comment 4 Per Arne Vollan 2016-07-01 10:28:22 PDT 
(In reply to comment #3)
> Comment on attachment 282545 [details]
> Patch
> 
> Oh, excellent! Thank you. r=me.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2016-07-03 23:30:27 PDT 
Committed r202799: <https://trac.webkit.org/changeset/202799>
Comment 6 WebKit Commit Bot 2016-07-08 10:15:57 PDT 
Re-opened since this is blocked by bug 159568
Comment 7 Per Arne Vollan 2016-07-11 07:01:22 PDT 
Created attachment 283314 [details]
Patch
Comment 8 Alex Christensen 2016-07-11 09:07:46 PDT 
Comment on attachment 283314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283314&action=review

> WebKitLibraries/ChangeLog:10
> +        * win/tools/scripts/version-stamp.pl: Replace forward slashes with backslashes.

The internal build uses Source/cmake/tools/scripts/version-stamp.pl.  Please change this one, too.
Comment 9 Per Arne Vollan 2016-07-11 10:31:34 PDT 
Created attachment 283321 [details]
Patch
Comment 10 Per Arne Vollan 2016-07-11 10:34:53 PDT 
(In reply to comment #8)
> Comment on attachment 283314 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283314&action=review
> 
> > WebKitLibraries/ChangeLog:10
> > +        * win/tools/scripts/version-stamp.pl: Replace forward slashes with backslashes.
> 
> The internal build uses Source/cmake/tools/scripts/version-stamp.pl.  Please
> change this one, too.

Thanks for reviewing :) Updated patch.
Comment 11 Brent Fulgham 2016-07-11 12:53:38 PDT 
Comment on attachment 283321 [details]
Patch

Thank you for correcting both version stamper scripts!
Comment 12 Konstantin Tokarev 2016-07-12 04:19:08 PDT 
Comment on attachment 283321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283321&action=review

> WebKitLibraries/win/tools/scripts/version-stamp.pl:93
> +$TARGET_PATH =~ s/\//\\/g;

Hint: when dealing with slashes in regexes use different separators, e.g. $TARGET_PATH =~ s{/}{\}g;
Comment 13 Per Arne Vollan 2016-07-12 06:02:13 PDT 
Committed r203111: <https://trac.webkit.org/changeset/203111>
Comment 14 Per Arne Vollan 2016-07-13 06:55:33 PDT 
The DLLs will not be stamped if the environment variable WEBKIT_LIBRARIES is not set.
Comment 15 Per Arne Vollan 2016-07-13 07:03:27 PDT 
Created attachment 283526 [details]
Patch
Comment 16 Per Arne Vollan 2016-07-13 08:07:39 PDT 
Created attachment 283527 [details]
Patch
Comment 17 Per Arne Vollan 2016-07-13 10:51:50 PDT 
Thanks for reviewing!
Comment 18 Per Arne Vollan 2016-07-13 10:52:45 PDT 
Committed r203167: <https://trac.webkit.org/changeset/203167>