Bug 159345 – Make ResourceLoaderOptions derive from FetchOptions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

The goal is to remove loader options by corresponding fetch options (requestOriginPolicy by fetch mode for instance).
Code would look nicer if ResourceLoaderOptions was inherited from FetchOptions.

[youenn fablet]

Created attachment 282541 [details]
Patch

[Alex Christensen]

Comment on attachment 282541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282541&action=review

> Source/WebCore/Modules/fetch/FetchLoader.cpp:85
> +    // FIXME: Pass directly all fetch options to loader options.

Why not do this now?

[youenn fablet]

(In reply to comment #2)
> Comment on attachment 282541 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282541&action=review
> 
> > Source/WebCore/Modules/fetch/FetchLoader.cpp:85
> > +    // FIXME: Pass directly all fetch options to loader options.
> 
> Why not do this now?

We could do so.
I plan to make some refactoring to progressively use more fetch options in ResourceLoader.
This may make updating fetch tests while not everything is in place thus making some fetch tests changing of failure and so on.
For instance, cross-origin fetch option is currently not supported and it is best to keep this option as SameOrigin until things get properly fixed.

[WebKit Commit Bot]

Comment on attachment 282541 [details]
Patch

Clearing flags on attachment: 282541

Committed r202741: <http://trac.webkit.org/changeset/202741>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.