Bug 159345 - Make ResourceLoaderOptions derive from FetchOptions
Summary: Make ResourceLoaderOptions derive from FetchOptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 151937
  Show dependency treegraph
 
Reported: 2016-07-01 05:23 PDT by youenn fablet
Modified: 2016-07-01 10:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.94 KB, patch)
2016-07-01 05:33 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-07-01 05:23:05 PDT
The goal is to remove loader options by corresponding fetch options (requestOriginPolicy by fetch mode for instance).
Code would look nicer if ResourceLoaderOptions was inherited from FetchOptions.
Comment 1 youenn fablet 2016-07-01 05:33:52 PDT
Created attachment 282541 [details]
Patch
Comment 2 Alex Christensen 2016-07-01 09:31:03 PDT
Comment on attachment 282541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282541&action=review

> Source/WebCore/Modules/fetch/FetchLoader.cpp:85
> +    // FIXME: Pass directly all fetch options to loader options.

Why not do this now?
Comment 3 youenn fablet 2016-07-01 09:43:39 PDT
(In reply to comment #2)
> Comment on attachment 282541 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282541&action=review
> 
> > Source/WebCore/Modules/fetch/FetchLoader.cpp:85
> > +    // FIXME: Pass directly all fetch options to loader options.
> 
> Why not do this now?

We could do so.
I plan to make some refactoring to progressively use more fetch options in ResourceLoader.
This may make updating fetch tests while not everything is in place thus making some fetch tests changing of failure and so on.
For instance, cross-origin fetch option is currently not supported and it is best to keep this option as SameOrigin until things get properly fixed.
Comment 4 WebKit Commit Bot 2016-07-01 10:03:55 PDT
Comment on attachment 282541 [details]
Patch

Clearing flags on attachment: 282541

Committed r202741: <http://trac.webkit.org/changeset/202741>
Comment 5 WebKit Commit Bot 2016-07-01 10:03:59 PDT
All reviewed patches have been landed.  Closing bug.