Bug 159336 – Cleanup of MathML headers

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

Another small refactoring we can do after https://trac.webkit.org/wiki/MathML/Early_2016_Refactoring#Phase1 is improving the inheritance and visibility in MathML element and renderer classes. The hierarchy as changed a lot and these are not always respected:

* Use final for class that are not extended.
* Use final instead of override for virtual members that are not overridden by derived classes.
* Try and reduce the visibility of function members to private or protected as appropriate.

[Frédéric Wang (:fredw)]

Created attachment 283627 [details]
Patch

[Brady Eidson]

Comment on attachment 283627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283627&action=review

r- with prejudice

(j/k, but, in all seriousness, #pragma once is used *instead* of header guards, not in addition to them!

Otherwise nice cleanup.

> Source/WebCore/ChangeLog:9
> +        - Use #pragma once

Nice!

> Source/WebCore/mathml/MathMLElement.h:30
>  #ifndef MathMLElement_h
>  #define MathMLElement_h
> +#pragma once

...

NOOOooooooo!

> Source/WebCore/mathml/MathMLInlineContainerElement.h:29
>  #ifndef MathMLInlineContainerElement_h
>  #define MathMLInlineContainerElement_h
> +#pragma once

:(

> Source/WebCore/mathml/MathMLMathElement.h:29
>  #ifndef MathMLMathElement_h
>  #define MathMLMathElement_h
> +#pragma once

<weeps>

> Source/WebCore/mathml/MathMLMencloseElement.h:29
>  #ifndef MathMLMencloseElement_h
>  #define MathMLMencloseElement_h
> +#pragma once

etc etc etc

[Frédéric Wang (:fredw)]

Created attachment 283655 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 283655 [details]
Patch

Clearing flags on attachment: 283655

Committed r203228: <http://trac.webkit.org/changeset/203228>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.