WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159336
Cleanup of MathML headers
https://bugs.webkit.org/show_bug.cgi?id=159336
Summary
Cleanup of MathML headers
Frédéric Wang (:fredw)
Reported
2016-07-01 02:01:02 PDT
Another small refactoring we can do after
https://trac.webkit.org/wiki/MathML/Early_2016_Refactoring#Phase1
is improving the inheritance and visibility in MathML element and renderer classes. The hierarchy as changed a lot and these are not always respected: * Use final for class that are not extended. * Use final instead of override for virtual members that are not overridden by derived classes. * Try and reduce the visibility of function members to private or protected as appropriate.
Attachments
Patch
(26.74 KB, patch)
2016-07-14 01:50 PDT
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Patch
(32.56 KB, patch)
2016-07-14 10:05 PDT
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1
2016-07-14 01:50:51 PDT
Created
attachment 283627
[details]
Patch
Brady Eidson
Comment 2
2016-07-14 09:51:18 PDT
Comment on
attachment 283627
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=283627&action=review
r- with prejudice (j/k, but, in all seriousness, #pragma once is used *instead* of header guards, not in addition to them! Otherwise nice cleanup.
> Source/WebCore/ChangeLog:9 > + - Use #pragma once
Nice!
> Source/WebCore/mathml/MathMLElement.h:30 > #ifndef MathMLElement_h > #define MathMLElement_h > +#pragma once
... NOOOooooooo!
> Source/WebCore/mathml/MathMLInlineContainerElement.h:29 > #ifndef MathMLInlineContainerElement_h > #define MathMLInlineContainerElement_h > +#pragma once
:(
> Source/WebCore/mathml/MathMLMathElement.h:29 > #ifndef MathMLMathElement_h > #define MathMLMathElement_h > +#pragma once
<weeps>
> Source/WebCore/mathml/MathMLMencloseElement.h:29 > #ifndef MathMLMencloseElement_h > #define MathMLMencloseElement_h > +#pragma once
etc etc etc
Frédéric Wang (:fredw)
Comment 3
2016-07-14 10:05:28 PDT
Created
attachment 283655
[details]
Patch
WebKit Commit Bot
Comment 4
2016-07-14 11:00:06 PDT
Comment on
attachment 283655
[details]
Patch Clearing flags on attachment: 283655 Committed
r203228
: <
http://trac.webkit.org/changeset/203228
>
WebKit Commit Bot
Comment 5
2016-07-14 11:00:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug