Bug 159324 - Web Inspector: Cleanup inspector/console/console-message.html
Summary: Web Inspector: Cleanup inspector/console/console-message.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-06-30 17:55 PDT by Joseph Pecoraro
Modified: 2016-07-01 10:01 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.50 KB, patch)
2016-06-30 17:55 PDT, Joseph Pecoraro
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (783.04 KB, application/zip)
2016-06-30 18:43 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (789.59 KB, application/zip)
2016-06-30 18:45 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.41 MB, application/zip)
2016-06-30 18:52 PDT, Build Bot
no flags Details
[PATCH] Proposed Fix (3.31 KB, patch)
2016-06-30 19:17 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-06-30 17:55:05 PDT
I was testing ProtocolTest.debug and used this test. There were some easy cleanups I could do when I found stale code.
Comment 1 Joseph Pecoraro 2016-06-30 17:55:32 PDT
Created attachment 282497 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2016-06-30 18:43:25 PDT
Comment on attachment 282497 [details]
[PATCH] Proposed Fix

Attachment 282497 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1603672

New failing tests:
inspector/console/console-message.html
Comment 3 Build Bot 2016-06-30 18:43:27 PDT
Created attachment 282502 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-06-30 18:45:50 PDT
Comment on attachment 282497 [details]
[PATCH] Proposed Fix

Attachment 282497 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1603673

New failing tests:
inspector/console/console-message.html
Comment 5 Build Bot 2016-06-30 18:45:53 PDT
Created attachment 282503 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-06-30 18:52:48 PDT
Comment on attachment 282497 [details]
[PATCH] Proposed Fix

Attachment 282497 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1603682

New failing tests:
inspector/console/console-message.html
Comment 7 Build Bot 2016-06-30 18:52:50 PDT
Created attachment 282504 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Joseph Pecoraro 2016-06-30 19:16:20 PDT
Oops, forgot to update the results, hah.
Comment 9 Joseph Pecoraro 2016-06-30 19:17:31 PDT
Created attachment 282505 [details]
[PATCH] Proposed Fix
Comment 10 Brian Burg 2016-07-01 09:21:24 PDT
Comment on attachment 282505 [details]
[PATCH] Proposed Fix

rs=me
Comment 11 WebKit Commit Bot 2016-07-01 10:01:14 PDT
Comment on attachment 282505 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 282505

Committed r202740: <http://trac.webkit.org/changeset/202740>
Comment 12 WebKit Commit Bot 2016-07-01 10:01:19 PDT
All reviewed patches have been landed.  Closing bug.