Bug 159320 - Web Inspector: Uncaught Exception reporter should include the currently dispatching protocol event or request/response if applicable
Summary: Web Inspector: Uncaught Exception reporter should include the currently dispa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-30 15:48 PDT by BJ Burg
Modified: 2016-07-06 13:23 PDT (History)
6 users (show)

See Also:

Attachments
Pre-filled bug report with request/response dump (1.66 KB, text/plain)
2016-06-30 15:51 PDT, BJ Burg 		no flags Details
Proposed Fix (10.71 KB, patch)
2016-06-30 16:01 PDT, BJ Burg 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-06-30 15:48:55 PDT 
Sometimes this extra info enough to narrow down the problem a lot, and doesn't require all callers of WebInspector.reportInternalError to figure out the current event/response.
Comment 1 Radar WebKit Bug Importer 2016-06-30 15:49:20 PDT 
<rdar://problem/27117754>
Comment 2 BJ Burg 2016-06-30 15:51:37 PDT 
Created attachment 282483 [details]
Pre-filled bug report with request/response dump
Comment 3 BJ Burg 2016-06-30 16:01:44 PDT 
Created attachment 282486 [details]
Proposed Fix
Comment 4 Timothy Hatcher 2016-06-30 16:06:10 PDT 
Comment on attachment 282486 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282486&action=review

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:216
> +        let responseData = {command, request:messageObject, callback};

Missing space after colon.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:237
> +        let responseData = {command, request:messageObject};

Missing space after colon.
Comment 5 Joseph Pecoraro 2016-06-30 16:44:44 PDT 
Comment on attachment 282486 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282486&action=review

> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:192
> +        return string.length > 500 ? string.substr(0, 500) + "..." : string;

Actual ellipsis? =)

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:50
> +        }

Style: semicolon.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:184
> +    get currentDispatchState() { return this._currentDispatchState; }

Style: Move this up with the other accessors.
Comment 6 BJ Burg 2016-07-06 13:23:23 PDT 
Committed r202875: <http://trac.webkit.org/changeset/202875>