Bug 159314 - REGRESSION(r202676): This change caused storage/websql tests to crash on Mac and iOS WK1 (Requested by ryanhaddad on #webkit).
Summary: REGRESSION(r202676): This change caused storage/websql tests to crash on Mac ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 159255
  Show dependency tree / graph
 
Reported: 2016-06-30 13:41 PDT by WebKit Commit Bot
Modified: 2016-07-04 11:06 PDT (History)
3 users (show)

See Also:

Attachments
ROLLOUT of r202676 (23.60 KB, patch)
2016-06-30 13:41 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2016-06-30 13:41:26 PDT 
http://trac.webkit.org/changeset/202676 broke the build:
This change caused storage/websql tests to crash on Mac and iOS WK1 (Requested by ryanhaddad on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2016-06-30 13:41:58 PDT 
Created attachment 282461 [details]
ROLLOUT of r202676

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ryan Haddad 2016-06-30 13:45:07 PDT 
Comment on attachment 282461 [details]
ROLLOUT of r202676

Clearing flags on attachment: 282461

Committed r202698: <http://trac.webkit.org/changeset/202698>
Comment 3 Ryan Haddad 2016-06-30 13:45:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Gyuyoung Kim 2016-07-04 02:45:19 PDT 
(In reply to comment #3)
> All reviewed patches have been landed.  Closing bug.

Ryan, do you know how to test mac-wk1 ? I don't know how to test mac-wk1 in latest code.
Comment 5 Ryan Haddad 2016-07-04 11:06:48 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > All reviewed patches have been landed.  Closing bug.
> 
> Ryan, do you know how to test mac-wk1 ? I don't know how to test mac-wk1 in
> latest code.

Passing the -1 flag will use DumpRenderTree / WK1 for LayoutTests. For example:

run-webkit-tests --debug -1 storage/websql