Bug 159310 - HTMLAttachment elements don't receive clicks after the first on iOS
Summary: HTMLAttachment elements don't receive clicks after the first on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified iOS 9.3
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-30 13:23 PDT by Enrica Casucci
Modified: 2016-07-05 15:24 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2016-06-30 13:28 PDT, Enrica Casucci
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2016-06-30 13:23:34 PDT
The first click on the element selects it. On iOS we prevent clicks to go through on a selected element, in order to toggle the selection menu.

rdar://problem/25776940
Comment 1 Enrica Casucci 2016-06-30 13:28:38 PDT
Created attachment 282458 [details]
Patch
Comment 2 Tim Horton 2016-06-30 13:29:38 PDT
Is this testable?
Comment 3 WebKit Commit Bot 2016-06-30 13:30:14 PDT
Attachment 282458 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLAttachmentElement.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Enrica Casucci 2016-06-30 15:21:23 PDT
(In reply to comment #2)
> Is this testable?

Actually I think so, even without using gestures.
Comment 5 Enrica Casucci 2016-06-30 16:45:15 PDT
We already have a test that checks the selection of the attachment element. I just need to change it to reliably testing on iOS too. I'll add it to the patch before landing.
Comment 6 Enrica Casucci 2016-07-05 15:24:56 PDT
Updated test to correctly detect new behavior.

Committed revision 202835.