Bug 159299 - [Win][Debug] Assertion fails in TestWTF.
Summary: [Win][Debug] Assertion fails in TestWTF.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-30 06:49 PDT by Per Arne Vollan
Modified: 2016-06-30 11:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2016-06-30 06:57 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-06-30 06:49:46 PDT
The assert in the & operator in the UniqueRef class fails, because the UniqueRef instance has been moved.
The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing the assertion failure.

>	WTF.dll!WTFCrash() Line 317	C++
 	TestWTFLib.dll!WTF::UniqueRef<TestWebKitAPI::A>::operator&() Line 54	C++
 	TestWTFLib.dll!TestWebKitAPI::WTF_UniqueRef_Test::TestBody() Line 83	C++
 	TestWTFLib.dll!testing::Test::Run() Line 2070	C++
 	TestWTFLib.dll!testing::internal::TestInfoImpl::Run() Line 2318	C++
 	TestWTFLib.dll!testing::TestCase::Run() Line 2421	C++
 	TestWTFLib.dll!testing::internal::UnitTestImpl::RunAllTests() Line 4025	C++
 	TestWTFLib.dll!testing::UnitTest::Run() Line 3677	C++
 	TestWTFLib.dll!TestWebKitAPI::TestsController::run(int argc, char * * argv) Line 80	C++
 	TestWTFLib.dll!main(int argc, char * * argv) Line 53	C++
 	TestWTFLib.dll!dllLauncherEntryPoint(int argc, char * * argv) Line 60	C++
 	TestWTF.exe!main(int argc, const char * * argv) Line 247	C++
Comment 1 Per Arne Vollan 2016-06-30 06:57:17 PDT
Created attachment 282436 [details]
Patch
Comment 2 WebKit Commit Bot 2016-06-30 10:49:15 PDT
Comment on attachment 282436 [details]
Patch

Clearing flags on attachment: 282436

Committed r202686: <http://trac.webkit.org/changeset/202686>
Comment 3 WebKit Commit Bot 2016-06-30 10:49:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Per Arne Vollan 2016-06-30 11:20:36 PDT
Thanks for reviewing :)