Bug 159295 - [css-grid] Handle alignment with orthogonal flows
Summary: [css-grid] Handle alignment with orthogonal flows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: BlinkMergeCandidate
: 107738 (view as bug list)
Depends on: 159294
Blocks: 60731 91512
  Show dependency tree / graph
 
Reported: 2016-06-30 04:08 PDT by Javier Fernandez
Modified: 2016-07-27 23:00 PDT (History)
9 users (show)

See Also:

Attachments
Patch (43.86 KB, patch)
2016-07-21 07:24 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (43.83 KB, patch)
2016-07-26 00:38 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (43.84 KB, patch)
2016-07-26 05:56 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2016-06-30 04:08:13 PDT 
Since Grid Layout doe snot support orthogonal flows, the alignment logic lacks support for that cases as well.
Comment 1 Javier Fernandez 2016-07-21 07:24:38 PDT 
Created attachment 284214 [details]
Patch
Comment 2 Darin Adler 2016-07-22 22:31:38 PDT 
Comment on attachment 284214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284214&action=review

> Source/WebCore/rendering/RenderGrid.cpp:2102
> +        // TODO (lajava): Should we implement this logic in a generic utility function ?

Looks like a comment using some other project’s competing standards. Maybe Chromium?

> Source/WebCore/rendering/RenderGrid.cpp:2115
> +        // TODO (lajava): Should we implement this logic in a generic utility function ?

Ditto.

> Source/WebCore/rendering/RenderGrid.cpp:2167
> +        // TODO (lajava): Should we implement this logic in a generic utility function ?

Ditto.

> Source/WebCore/rendering/RenderGrid.cpp:2180
> +        // TODO (lajava): Should we implement this logic in a generic utility function ?

Ditto.
Comment 3 Javier Fernandez 2016-07-26 00:38:45 PDT 
Created attachment 284568 [details]
Patch

Applied suggested changes.
Comment 4 Javier Fernandez 2016-07-26 05:56:51 PDT 
Created attachment 284584 [details]
Patch

Patch rebased.
Comment 5 WebKit Commit Bot 2016-07-27 03:08:31 PDT 
Comment on attachment 284584 [details]
Patch

Clearing flags on attachment: 284584

Committed r203771: <http://trac.webkit.org/changeset/203771>
Comment 6 WebKit Commit Bot 2016-07-27 03:08:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Javier Fernandez 2016-07-27 23:00:23 PDT 
*** Bug 107738 has been marked as a duplicate of this bug. ***