Bug 159268 – Factor pending CSS resources into a struct

• Status: NEW
• Component: CSS

[Antti Koivisto]

To fix resource loading related re-entrancy issues in StyleResolver we should move the triggering of resource loads outside resource loader. The first step for that is to capture them to a struct.

[Antti Koivisto]

Created attachment 282370 [details]
Patch

[Build Bot]

Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1596352

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html

[Build Bot]

Created attachment 282373 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1596360

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html

[Build Bot]

Created attachment 282374 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1596381

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html

[Build Bot]

Created attachment 282379 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1596432

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html

[Build Bot]

Created attachment 282380 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Antti Koivisto]

Created attachment 282381 [details]
Patch

[Andreas Kling]

Comment on attachment 282381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282381&action=review

> Source/WebCore/style/StylePendingResources.h:51
> +void loadPendingResources(PendingResources&, Document&, RenderStyle&, const Element*);

the PendingResources& here could be const

[Antti Koivisto]

This is work towards fixing rdar://problem/26184868