Bug 159268 - Factor pending CSS resources into a struct
Summary: Factor pending CSS resources into a struct
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-29 12:37 PDT by Antti Koivisto
Modified: 2016-06-29 16:10 PDT (History)
2 users (show)

See Also:


Attachments
Patch (38.78 KB, patch)
2016-06-29 13:50 PDT, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.25 MB, application/zip)
2016-06-29 14:37 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.25 MB, application/zip)
2016-06-29 14:41 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.89 MB, application/zip)
2016-06-29 14:57 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.12 MB, application/zip)
2016-06-29 15:00 PDT, Build Bot
no flags Details
Patch (39.12 KB, patch)
2016-06-29 15:24 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-06-29 12:37:09 PDT
To fix resource loading related re-entrancy issues in StyleResolver we should move the triggering of resource loads outside resource loader. The first step for that is to capture them to a struct.
Comment 1 Antti Koivisto 2016-06-29 13:50:55 PDT
Created attachment 282370 [details]
Patch
Comment 2 Build Bot 2016-06-29 14:37:45 PDT
Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1596352

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html
Comment 3 Build Bot 2016-06-29 14:37:48 PDT
Created attachment 282373 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-06-29 14:41:08 PDT
Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1596360

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html
Comment 5 Build Bot 2016-06-29 14:41:11 PDT
Created attachment 282374 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-06-29 14:57:34 PDT
Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1596381

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html
Comment 7 Build Bot 2016-06-29 14:57:37 PDT
Created attachment 282379 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-06-29 15:00:51 PDT
Comment on attachment 282370 [details]
Patch

Attachment 282370 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1596432

New failing tests:
http/tests/security/shape-image-cors-redirect.html
http/tests/security/shape-image-cors.html
Comment 9 Build Bot 2016-06-29 15:00:54 PDT
Created attachment 282380 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 10 Antti Koivisto 2016-06-29 15:24:47 PDT
Created attachment 282381 [details]
Patch
Comment 11 Andreas Kling 2016-06-29 15:42:28 PDT
Comment on attachment 282381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282381&action=review

> Source/WebCore/style/StylePendingResources.h:51
> +void loadPendingResources(PendingResources&, Document&, RenderStyle&, const Element*);

the PendingResources& here could be const
Comment 12 Antti Koivisto 2016-06-29 16:10:36 PDT
This is work towards fixing rdar://problem/26184868