Bug 159264 - [GTK] Debug build broken with Clang
Summary: [GTK] Debug build broken with Clang
Status: RESOLVED DUPLICATE of bug 159931
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-29 09:00 PDT by Carlos Alberto Lopez Perez
Modified: 2016-07-20 13:20 PDT (History)
8 users (show)

See Also:

Attachments
Preliminary approach (469 bytes, patch)
2016-06-29 09:12 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2016-06-29 09:00:52 PDT 
Trying to do a debug build of WebKitGTK+ (on r202623) with Clang and I get this build error:


[5825/6148] Linking CXX shared library lib/libwebkit2gtk-4.0.so.37.14.1
FAILED: : && /usr/bin/clang++  -fPIC -Wno-error  -std=c++1y -fcolor-diagnostics -gsplit-dwarf -Qunused-arguments -g  -Wl,--no-undefined  -L/home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib  -fuse-ld=gold -Wl,--disable-new-dtags -Wl,--gdb-index -Wl,--gdb-index -shared -Wl,-soname,libwebkit2gtk-4.0.so.37 -o lib/libwebkit2gtk-4.0.so.37.14.1 @CMakeFiles/WebKit2.rsp  && :
../../Source/WebKit2/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:76: error: undefined reference to 'WebKit::NetworkCache::Data::~Data()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.


However, the same build with GCC (gcc-4.9) works.
Comment 1 Javier Fernandez 2016-06-29 09:12:46 PDT 
Created attachment 282350 [details]
Preliminary approach

This simple change seems to solve the issue, but I guess we should figure out why we need a destructor now and if that's the case, implement it properly instead of just an empty one.
Comment 2 Javier Fernandez 2016-07-15 02:53:48 PDT 
The bug is only reproducible using clang versions above 3.5 .
Comment 3 Javier Fernandez 2016-07-15 07:46:21 PDT 
I'm not totally sure, but perhaps bug #154885 is related to this one.
Comment 4 Michael Catanzaro 2016-07-20 13:20:22 PDT 

*** This bug has been marked as a duplicate of bug 159931 ***