Bug 15926 - [GTK] WebKitPage map handler is redundant.
Summary: [GTK] WebKitPage map handler is redundant.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Trivial
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2007-11-09 15:23 PST by Xan Lopez
Modified: 2007-11-11 04:29 PST (History)
0 users

See Also:

0001-The-page-map-method-is-redundant-GtkContainer-does.patch (2.36 KB, patch)
2007-11-09 15:25 PST, Xan Lopez
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2007-11-09 15:23:16 PST
The parent class handler (GtkContainer's) already does what we are doing, if I'm not missing something.
Comment 1 Xan Lopez 2007-11-09 15:25:01 PST
Created attachment 17162 [details]

Subject: [PATCH] The page map method is redundant (GtkContainer does the same and a little more).

 WebKit/gtk/Api/webkitgtkpage.cpp |   14 --------------
 WebKit/gtk/ChangeLog             |   12 ++++++++++++
 2 files changed, 12 insertions(+), 14 deletions(-)
Comment 2 Alp Toker 2007-11-09 16:29:16 PST
Comment on attachment 17162 [details]

ChangeLog needs spaces, not tabs, but patch looks good. Thanks
Comment 3 Alp Toker 2007-11-09 16:33:03 PST
Landed in r27658.