Bug 159236 – Web Inspector: Show Shadow Root type in DOM Tree

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Show Shadow Root type in DOM Tree

Test:
<input id="host-user-agent" controls>
<div id="host-closed"></div>
<div id="host-open"></div>
<div id="no-host"></div>
<script>
(function() {
    var shadowRootClosed = document.getElementById("host-closed").attachShadow({mode: "closed"});
    shadowRootClosed.appendChild(document.createTextNode("closed"));

    var shadowRootOpen = document.getElementById("host-open").attachShadow({mode: "open"});
    shadowRootOpen.appendChild(document.createTextNode("open"));
})();
</script>

Steps to Reproduce:
1. Inspect test case
2. Expand all nodes in the DOM Tree
  => Should see different types of Shadow Roots under the different shadow host elements (UserAgent, Closed, and Open)

[Radar WebKit Bug Importer]

<rdar://problem/27068521>

[Joseph Pecoraro]

Created attachment 282300 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 282301 [details]
[IMAGE] Before

[Joseph Pecoraro]

Created attachment 282302 [details]
[IMAGE] After

[Timothy Hatcher]

Comment on attachment 282300 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282300&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:61
> +        case WebInspector.DOMNode.ShadowRootType.Open:
> +            return "open";
> +        case WebInspector.DOMNode.ShadowRootType.Closed:
> +            return "closed";

Title case? Localized?

[Joseph Pecoraro]

Created attachment 282360 [details]
[PATCH] Proposed Fix

I changed to UIString names. I was making them "open" and "closed" to match the {mode: <mode>} name. But I guess we localize names in other places.

[WebKit Commit Bot]

Comment on attachment 282360 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 282360

Committed r202634: <http://trac.webkit.org/changeset/202634>