Bug 159232 - Enhance shouldNotThrow()/shouldThrow() to accept functions and a descriptive message
Summary: Enhance shouldNotThrow()/shouldThrow() to accept functions and a descriptive ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks: CVE-2016-4767
  Show dependency tree / graph
 
Reported: 2016-06-28 15:56 PDT by David Kilzer (:ddkilzer)
Modified: 2017-04-26 19:18 PDT (History)
18 users (show)

See Also:

Attachments
Patch v1 (26.83 KB, patch)
2016-06-28 16:03 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-06-28 15:56:43 PDT 
Enhance shouldNotThrow()/shouldThrow() to accept functions and a descriptive message.

These will be used in a future patch ported from Blink.
Comment 1 David Kilzer (:ddkilzer) 2016-06-28 16:03:38 PDT 
Created attachment 282292 [details]
Patch v1
Comment 2 Alex Christensen 2016-06-28 16:09:04 PDT 
(In reply to comment #0)
> These will be used in a future patch ported from Blink.
Which patch?
Comment 3 David Kilzer (:ddkilzer) 2016-06-28 17:20:47 PDT 
(In reply to comment #2)
> (In reply to comment #0)
> > These will be used in a future patch ported from Blink.
> Which patch?

Bug 159238
Comment 4 Brent Fulgham 2016-06-28 17:50:54 PDT 
Comment on attachment 282292 [details]
Patch v1

Looks great! r=me.
Comment 5 WebKit Commit Bot 2016-06-28 21:17:57 PDT 
Comment on attachment 282292 [details]
Patch v1

Clearing flags on attachment: 282292

Committed r202609: <http://trac.webkit.org/changeset/202609>
Comment 6 WebKit Commit Bot 2016-06-28 21:18:03 PDT 
All reviewed patches have been landed.  Closing bug.