Bug 159227 - JSRopeString should use release asserts, not debug asserts, about substring bounds
Summary: JSRopeString should use release asserts, not debug asserts, about substring b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-28 14:00 PDT by Filip Pizlo
Modified: 2016-06-28 14:04 PDT (History)
5 users (show)

See Also:

Attachments
the patch (2.12 KB, patch)
2016-06-28 14:01 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-06-28 14:00:04 PDT 
According to my experiments this change costs nothing.  That's not surprising since the most common way to construct a rope these days is inlined into the JIT, which does its own safety checks.  This makes us crash sooner rather than corrupting memory.
Comment 1 Filip Pizlo 2016-06-28 14:01:08 PDT 
Created attachment 282282 [details]
the patch
Comment 2 Filip Pizlo 2016-06-28 14:04:04 PDT 
Landed in https://trac.webkit.org/changeset/202585