Bug 159222 - reportAbandonedObjectGraph should report abandoned bytes based on capacity() so it works even if a GC has never happened
Summary: reportAbandonedObjectGraph should report abandoned bytes based on capacity() ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-28 13:22 PDT by Saam Barati
Modified: 2016-07-05 12:49 PDT (History)
12 users (show)

See Also:


Attachments
patch (3.01 KB, patch)
2016-06-28 16:11 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-06-28 13:22:21 PDT
....
Comment 1 Saam Barati 2016-06-28 13:23:42 PDT
<rdar://problem/27001991>
Comment 2 Saam Barati 2016-06-28 16:11:32 PDT
Created attachment 282294 [details]
patch
Comment 3 Geoffrey Garen 2016-06-29 11:16:37 PDT
Comment on attachment 282294 [details]
patch

r=me

I think we want an API test that mimics the test you've been working with -- allocate and call JSGarbageCollect in a loop, verify that not too many objects build up.

I think you mentioned that this patch alone doesn't make that test pass. So, we probably need a follow-up patch with a test and a fix for the remaining bug.
Comment 4 Saam Barati 2016-07-05 12:30:54 PDT
Opened a bug to fix the remaining problem:
https://bugs.webkit.org/show_bug.cgi?id=159431
Comment 5 WebKit Commit Bot 2016-07-05 12:49:53 PDT
Comment on attachment 282294 [details]
patch

Clearing flags on attachment: 282294

Committed r202827: <http://trac.webkit.org/changeset/202827>
Comment 6 WebKit Commit Bot 2016-07-05 12:49:57 PDT
All reviewed patches have been landed.  Closing bug.