Bug 159220 – REGRESSION(r201405): Fullscreen video no longer enters low-power mode

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

REGRESSION(r201405): Fullscreen video no longer enters low-power mode

[Jer Noble]

<rdar://problem/26701056>

[Jer Noble]

Created attachment 282274 [details]
Patch

[Brent Fulgham]

Comment on attachment 282274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282274&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1320
> +

#if PLATFORM(COCOA)

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1324
> +    m_process->send(Messages::WebPage::SetTopContentInsetFenced(contentInset, fenceAttachment), m_pageID);

#else
    m_process->send(Messages::WebPage::SetTopContentInset(contentInset);
#endif

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2459
>  

This new message handler probably needs to be #if PLATFORM(COCOA)

> Source/WebKit2/WebProcess/WebPage/WebPage.h:1055
>  

#if PLATFORM(COCOA)

> Source/WebKit2/WebProcess/WebPage/WebPage.h:1056
> +    void setTopContentInsetFenced(float, IPC::Attachment);

#endif

> Source/WebKit2/WebProcess/WebPage/WebPage.messages.in:32
> +    SetTopContentInsetFenced(float contentInset, IPC::Attachment fencePort)

Maybe you need to keep both messages, the original for #if !PLATFORM(COCOA).

[Jer Noble]

(In reply to comment #3)
> Comment on attachment 282274 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282274&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:1320
> > +
> 
> #if PLATFORM(COCOA)
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:1324
> > +    m_process->send(Messages::WebPage::SetTopContentInsetFenced(contentInset, fenceAttachment), m_pageID);
> 
> #else
>     m_process->send(Messages::WebPage::SetTopContentInset(contentInset);
> #endif
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2459
> >  
> 
> This new message handler probably needs to be #if PLATFORM(COCOA)
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.h:1055
> >  
> 
> #if PLATFORM(COCOA)
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.h:1056
> > +    void setTopContentInsetFenced(float, IPC::Attachment);
> 
> #endif
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.messages.in:32
> > +    SetTopContentInsetFenced(float contentInset, IPC::Attachment fencePort)
> 
> Maybe you need to keep both messages, the original for #if !PLATFORM(COCOA).

Sure thing.

[Jer Noble]

Created attachment 282494 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 282494 [details]
Patch for landing

Clearing flags on attachment: 282494

Committed r202763: <http://trac.webkit.org/changeset/202763>