Bug 159220 - REGRESSION(r201405): Fullscreen video no longer enters low-power mode
Summary: REGRESSION(r201405): Fullscreen video no longer enters low-power mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-28 13:13 PDT by Jer Noble
Modified: 2016-10-31 09:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.85 KB, patch)
2016-06-28 13:17 PDT, Jer Noble 		bdakin: review+
Details | Formatted Diff | Diff
Patch for landing (7.01 KB, patch)
2016-06-30 17:06 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-06-28 13:13:44 PDT 
REGRESSION(r201405): Fullscreen video no longer enters low-power mode
Comment 1 Jer Noble 2016-06-28 13:14:13 PDT 
<rdar://problem/26701056>
Comment 2 Jer Noble 2016-06-28 13:17:53 PDT 
Created attachment 282274 [details]
Patch
Comment 3 Brent Fulgham 2016-06-28 15:31:59 PDT 
Comment on attachment 282274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282274&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1320
> +

#if PLATFORM(COCOA)

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1324
> +    m_process->send(Messages::WebPage::SetTopContentInsetFenced(contentInset, fenceAttachment), m_pageID);

#else
    m_process->send(Messages::WebPage::SetTopContentInset(contentInset);
#endif

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2459
>  

This new message handler probably needs to be #if PLATFORM(COCOA)

> Source/WebKit2/WebProcess/WebPage/WebPage.h:1055
>  

#if PLATFORM(COCOA)

> Source/WebKit2/WebProcess/WebPage/WebPage.h:1056
> +    void setTopContentInsetFenced(float, IPC::Attachment);

#endif

> Source/WebKit2/WebProcess/WebPage/WebPage.messages.in:32
> +    SetTopContentInsetFenced(float contentInset, IPC::Attachment fencePort)

Maybe you need to keep both messages, the original for #if !PLATFORM(COCOA).
Comment 4 Jer Noble 2016-06-30 15:17:33 PDT 
(In reply to comment #3)
> Comment on attachment 282274 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282274&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:1320
> > +
> 
> #if PLATFORM(COCOA)
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:1324
> > +    m_process->send(Messages::WebPage::SetTopContentInsetFenced(contentInset, fenceAttachment), m_pageID);
> 
> #else
>     m_process->send(Messages::WebPage::SetTopContentInset(contentInset);
> #endif
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2459
> >  
> 
> This new message handler probably needs to be #if PLATFORM(COCOA)
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.h:1055
> >  
> 
> #if PLATFORM(COCOA)
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.h:1056
> > +    void setTopContentInsetFenced(float, IPC::Attachment);
> 
> #endif
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.messages.in:32
> > +    SetTopContentInsetFenced(float contentInset, IPC::Attachment fencePort)
> 
> Maybe you need to keep both messages, the original for #if !PLATFORM(COCOA).

Sure thing.
Comment 5 Jer Noble 2016-06-30 17:06:12 PDT 
Created attachment 282494 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2016-07-01 16:42:12 PDT 
Comment on attachment 282494 [details]
Patch for landing

Clearing flags on attachment: 282494

Committed r202763: <http://trac.webkit.org/changeset/202763>