Bug 159206 - [EFL] Fix build when media-stream is enabled.
Summary: [EFL] Fix build when media-stream is enabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-28 03:06 PDT by Hunseop Jeong
Modified: 2016-07-08 00:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.98 KB, patch)
2016-07-05 00:59 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2016-06-28 03:06:06 PDT 
lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp.o):RealtimeMediaSourceCenterOwr.cpp:function WebCore::RealtimeMediaSourceCenterOwr::validateRequestConstraints(WebCore::MediaStreamCreationClient*, WTF::RefPtr<WebCore::MediaConstraints>&, WTF::RefPtr<WebCore::MediaConstraints>&): error: undefined reference to 'owr_get_capture_sources'
lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp.o):RealtimeMediaSourceCenterOwr.cpp:function WebCore::RealtimeMediaSourceCenterOwr::mediaSourcesAvailable(_GList*): error: undefined reference to 'owr_media_source_get_type'
lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/mediastream/openwebrtc/OpenWebRTCUtilities.cpp.o):OpenWebRTCUtilities.cpp:function WebCore::initializeOpenWebRTC(): error: undefined reference to 'owr_init'
collect2: error: ld returned 1 exit status
Comment 1 Hunseop Jeong 2016-06-28 03:18:08 PDT 
PkgConfig fails to find the OPENWEBRTC package.

-- checking for modules 'openwebrtc-0.3;openwebrtc-gst-0.3'
--   package 'openwebrtc-0.3' not found
--   package 'openwebrtc-gst-0.3' not found
-- Could NOT find OPENWEBRTC (missing:  OPENWEBRTC_INCLUDE_DIRS OPENWEBRTC_LIBRARIES)
Comment 2 Hunseop Jeong 2016-07-05 00:59:24 PDT 
Created attachment 282756 [details]
Patch
Comment 3 Gyuyoung Kim 2016-07-05 19:46:00 PDT 
Comment on attachment 282756 [details]
Patch

LGTM. Then can we enable media-stream feature now ?
Comment 4 Hunseop Jeong 2016-07-06 00:19:18 PDT 
(In reply to comment #3)
> Comment on attachment 282756 [details]
> Patch
> 
> LGTM. Then can we enable media-stream feature now ?

No,, I test the fast/mediastream tests with media-stream. But 25 tests ran as expected, 48 didn't. So we need more time to enable the mediastream.
Comment 5 WebKit Commit Bot 2016-07-08 00:05:46 PDT 
Comment on attachment 282756 [details]
Patch

Clearing flags on attachment: 282756

Committed r202969: <http://trac.webkit.org/changeset/202969>
Comment 6 WebKit Commit Bot 2016-07-08 00:05:50 PDT 
All reviewed patches have been landed.  Closing bug.