Bug 159200 - [css-grid] Disallow repeat() in grid-template shorthand
Summary: [css-grid] Disallow repeat() in grid-template shorthand
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
Depends on:
Blocks: 60731
  Show dependency treegraph
Reported: 2016-06-28 01:24 PDT by Manuel Rego Casasnovas
Modified: 2016-07-08 01:58 PDT (History)
3 users (show)

See Also:

Patch (16.59 KB, patch)
2016-06-28 02:14 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (16.74 KB, patch)
2016-07-06 06:01 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-06-28 01:24:14 PDT
As discussed on www-style, "repeat()" notation shouldn't be allowed
in the ASCII branch of the grid-template shorthand.
See: https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

The syntax on the spec has been updated and avoid the use of <track-list>:

For example the following declaration should be invalid:
  grid-template: "a b" / repeat(2, 100px);
Comment 1 Manuel Rego Casasnovas 2016-06-28 02:14:13 PDT
Created attachment 282227 [details]
Comment 2 Sergio Villar Senin 2016-07-06 02:50:06 PDT
Comment on attachment 282227 [details]

Nice patch but better use an enumerated type instead of a boolean.
Comment 3 Manuel Rego Casasnovas 2016-07-06 06:01:30 PDT
Created attachment 282883 [details]

Thanks for the review, new patch using an enum uploaded. PTAL.
Comment 4 WebKit Commit Bot 2016-07-08 01:58:29 PDT
Comment on attachment 282883 [details]

Clearing flags on attachment: 282883

Committed r202972: <http://trac.webkit.org/changeset/202972>
Comment 5 WebKit Commit Bot 2016-07-08 01:58:32 PDT
All reviewed patches have been landed.  Closing bug.