Cross-domain video loads do not prompt for authorization.
<rdar://problem/26234612>
Created attachment 282213 [details] Patch
Comment on attachment 282213 [details] Patch This can definitely be tested. setAuthenticationUsername, setAuthenticationPassword, create a video element that responds with a basic authentication challenge if there are no credentials.
Those tests already exist (cross domain even) and don't catch this. The problem is not whether or not a credential is given, but whether the user is asked for one if there is no stored credential.
See: <http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/media/video-auth.html>
So you're saying if you change 127.0.0.1 in that test to localhost, it won't catch this problem? I'll have to look at this when I have a machine with Sierra on it.
(In reply to comment #6) > So you're saying if you change 127.0.0.1 in that test to localhost, it won't > catch this problem? I'll have to look at this when I have a machine with > Sierra on it. Yep. Just ran that test myself. No matter whether you use 127.0.0.1 or localhost in the <video> src, you still get an auth challenge.
(In reply to comment #7) > (In reply to comment #6) > > So you're saying if you change 127.0.0.1 in that test to localhost, it won't > > catch this problem? I'll have to look at this when I have a machine with > > Sierra on it. > > Yep. Just ran that test myself. No matter whether you use 127.0.0.1 or > localhost in the <video> src, you still get an auth challenge. Ack, I'm wrong. I ran it against my fixed build, not against shipping. On shipping, changing 127.0.0.1 to localhost does cause an error. I'll add a test.
Created attachment 282249 [details] Patch
Comment on attachment 282249 [details] Patch Attachment 282249 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1586957 New failing tests: http/tests/media/video-auth.html
Created attachment 282250 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 282249 [details] Patch Attachment 282249 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1586959 New failing tests: http/tests/media/video-auth.html
Created attachment 282251 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 282249 [details] Patch Attachment 282249 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1587111 New failing tests: animations/multiple-backgrounds.html
Created attachment 282256 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 282249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282249&action=review R=me, but please provide new baselines before landing. > LayoutTests/ChangeLog:5 > + <rdar://problem/26234612> This test looks good, but you forgot to include new baselines! :-)
Yep
Committed r202579: <http://trac.webkit.org/changeset/202579>
The test added with this change is failing on mac-wk2: http/tests/media/video-auth.html <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmedia%2Fvideo-auth.html>
Rebaselined test for WK2 in <https://trac.webkit.org/r202587>