Bug 159193 – [JSC] Fix build warning since r202502

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: JavaScriptCore

[Gyuyoung Kim]

r202502 made a build warning because there is no default return value in TypeMap::at().

[107/4159] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/b3/B3InsertionSet.cpp.o
In file included from ../../Source/JavaScriptCore/b3/B3InsertionSet.h:33:0,
                 from ../../Source/JavaScriptCore/b3/B3InsertionSet.cpp:27:
../../Source/JavaScriptCore/b3/B3TypeMap.h: In member function ‘T& JSC::B3::TypeMap<T>::at(JSC::B3::Type) [with T = JSC::B3::Value*]’:
../../Source/JavaScriptCore/b3/B3TypeMap.h:62:5: warning: control reaches end of non-void function [-Wreturn-type]
     }
     ^

[Gyuyoung Kim]

Created attachment 282210 [details]
Patch

[Yusuke Suzuki]

I think we should fix this like that https://bugs.webkit.org/show_bug.cgi?id=152887.
See the context. https://bugs.webkit.org/show_bug.cgi?id=150794#c7

[Gyuyoung Kim]

Created attachment 282212 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #2)
> I think we should fix this like that
> https://bugs.webkit.org/show_bug.cgi?id=152887.
> See the context. https://bugs.webkit.org/show_bug.cgi?id=150794#c7

Looks like this fix is better than me. Fixed.

[Yusuke Suzuki]

Comment on attachment 282212 [details]
Patch

r=me

[Gyuyoung Kim]

Created attachment 282219 [details]
Patch

[Gyuyoung Kim]

*** This bug has been marked as a duplicate of bug 159194 ***