Bug 159192 – Web Inspector: selectElement.options shows unexpected entries in console (named indexes beyond collection length)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
selectElement.options shows unexpected entries in console (named indexes beyond collection length)

Test:
<select id="x">
    <option name="1" id="attr_1" value="1"></option>
</select>

Steps to Reproduce:
1. js> x.options
2. Expand
  => Expected just the 1 option, instead saw the single option duplicated

Notes:
- options.length is (1), and [0] is the one option. However, "named index" ["1"] is because the <option> has a name of 1.
- We will just treat arrayLike objects more like Arrays, even if they are small, only provide values for 0..length
- Note this is special because in a collection the named indexes, though numeric, do not affect length. You can't do that with arrays.

[Joseph Pecoraro]

Created attachment 282208 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 282208 [details]
[PATCH] Proposed Fix

Attachment 282208 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1584212

New failing tests:
animations/multiple-backgrounds.html

[Build Bot]

Created attachment 282211 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[WebKit Commit Bot]

Comment on attachment 282208 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 282208

Committed r202568: <http://trac.webkit.org/changeset/202568>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.