Bug 159183 - Web Inspector: QuickConsole should update its selection when RuntimeManager.defaultExecutionContextIdentifier changes
Summary: Web Inspector: QuickConsole should update its selection when RuntimeManager.d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-06-27 17:23 PDT by BJ Burg
Modified: 2016-06-28 11:40 PDT (History)
7 users (show)

See Also:

Attachments
Proposed Fix (20.16 KB, patch)
2016-06-27 21:17 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-06-27 17:23:22 PDT 
Make it respect the data in the model instead of the UI state.
Comment 1 BJ Burg 2016-06-27 21:17:50 PDT 
Created attachment 282207 [details]
Proposed Fix
Comment 2 WebKit Commit Bot 2016-06-28 08:12:31 PDT 
Comment on attachment 282207 [details]
Proposed Fix

Clearing flags on attachment: 282207

Committed r202566: <http://trac.webkit.org/changeset/202566>
Comment 3 WebKit Commit Bot 2016-06-28 08:12:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Joseph Pecoraro 2016-06-28 11:40:55 PDT 
Comment on attachment 282207 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282207&action=review

> Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js:155
>  WebInspector.RuntimeManager.Event = {
> -    DidEvaluate: "runtime-manager-did-evaluate"
> +    DidEvaluate: Symbol("runtime-manager-did-evaluate"),
> +    DefaultExecutionContextChanged: Symbol("runtime-manager-default-execution-context-changed"),
>  };

I don't think we use Symbols for event names anywhere else. Maybe we should start moving in that direction. We could shorten these event names, heh.

> Source/WebInspectorUI/UserInterface/Models/Frame.js:211
> +            this.dispatchEventToListeners(WebInspector.Frame.Event.ExecutionContextsCleared, {committingProvisionalLoad:!!committingProvisionalLoad, contexts});

Style: object literal style needs a space