Bug 159182 – Web Inspector: Uncaught Exception page never shows if exception is thrown while processing a protocol event

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

We catch, log, and drop the assertion on the floor. We should probably only do that if !DebugUIEnabled, so that we can easily file and fix these exceptions.

[Blaze Burg]

exception*

[Blaze Burg]

Created attachment 282307 [details]
Proposed Fix

[Joseph Pecoraro]

Comment on attachment 282307 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282307&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:2456
> +    } else if (optionalMessage)
> +        console.error(optionalMessage, error);

This `optionalMessage` stuff seems stale? Right now it looks like a ReferenceError.

> Source/WebInspectorUI/UserInterface/Base/Main.js:2459
> +}

Style: ;

> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:173
> +            if (entry.details) {
> +                lines.push("");
> +                lines.push("Additional Details:")
> +                for (let key in entry.details) {
> +                    let value = entry.details[key];
> +                    lines.push(`${indent}${key} --> ${value}`);
> +                }
> +            }

Seems this can be outside of the "if (entry.stack)" block.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:305
> +            WebInspector.reportInternalError(e, details);

Style: Inlining the details would look nicer!

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:357
> +            WebInspector.reportInternalError(e, details);

Style: Inlining the details would look nicer!

[Blaze Burg]

Committed r202657: <http://trac.webkit.org/changeset/202657>