Bug 159181 - Web Inspector: When modifying sessionStorage, localStorage gets updated
Summary: Web Inspector: When modifying sessionStorage, localStorage gets updated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-27 17:07 PDT by Joseph Pecoraro
Modified: 2016-06-27 17:56 PDT (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (11.35 KB, patch)
2016-06-27 17:13 PDT, Joseph Pecoraro 		timothy: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Landing (Test Fixes) (10.35 KB, patch)
2016-06-27 17:34 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-06-27 17:07:04 PDT 
Summary:
When modifying sessionStorage, localStorage gets updated

Steps to Reproduce:
1. Inspect <http://html5demos.com/storage>
2. Show Session Storage in Storage Tab
3. Type in the sessionStorage box in the web page
  => Expected Session Storage content view to update, it did not.
  => Instead, the Local Storage content view updates. Unexpected!

Notes:
- The domStorageItemUpdated event is saying isLocalStorage:true, that is wrong!
CONSOLE LOG event: {"method":"DOMStorage.domStorageItemUpdated","params":{"storageId":{"securityOrigin":"http://html5demos.com","isLocalStorage":true},"key":"timestamp","oldValue":"1467063160418","newValue":"1467063330376"}}
Comment 1 Radar WebKit Bug Importer 2016-06-27 17:07:28 PDT 
<rdar://problem/27043447>
Comment 2 Joseph Pecoraro 2016-06-27 17:13:35 PDT 
Created attachment 282188 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-06-27 17:27:11 PDT 
Comment on attachment 282188 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282188&action=review

> LayoutTests/inspector/storage/domStorage-events.html:33
> +    InspectorBackend.dumpInspectorProtocolMessages = true;

Do not leave these in when you commit.
Comment 4 Joseph Pecoraro 2016-06-27 17:34:26 PDT 
Created attachment 282193 [details]
[PATCH] For Landing (Test Fixes)
Comment 5 WebKit Commit Bot 2016-06-27 17:55:24 PDT 
Comment on attachment 282193 [details]
[PATCH] For Landing (Test Fixes)

Clearing flags on attachment: 282193

Committed r202529: <http://trac.webkit.org/changeset/202529>