Bug 159172 - REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
Summary: REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-red...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 159185
Blocks:
  Show dependency tree / graph
 
Reported: 2016-06-27 14:52 PDT by Jer Noble
Modified: 2016-06-27 23:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.07 KB, patch)
2016-06-27 15:08 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (8.44 KB, patch)
2016-06-27 15:17 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-06-27 14:52:43 PDT 
REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
Comment 1 Jer Noble 2016-06-27 14:53:08 PDT 
<rdar://problem/27030025>
Comment 2 Jer Noble 2016-06-27 15:08:17 PDT 
Created attachment 282173 [details]
Patch
Comment 3 Jer Noble 2016-06-27 15:17:29 PDT 
Created attachment 282176 [details]
Patch
Comment 4 Brent Fulgham 2016-06-27 16:29:54 PDT 
Comment on attachment 282176 [details]
Patch

LGTM. R=me.
Comment 5 WebKit Commit Bot 2016-06-27 16:56:28 PDT 
Comment on attachment 282176 [details]
Patch

Clearing flags on attachment: 282176

Committed r202520: <http://trac.webkit.org/changeset/202520>
Comment 6 WebKit Commit Bot 2016-06-27 16:56:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2016-06-27 17:34:54 PDT 
Re-opened since this is blocked by bug 159185
Comment 8 Ryan Haddad 2016-06-27 17:37:25 PDT 
(In reply to comment #7)
> Re-opened since this is blocked by bug 159185

/Volumes/Data/slave/elcapitan-32bit-release/build/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:74:17: error: property 'hasSingleSecurityOrigin' requires method 'hasSingleSecurityOrigin' to be defined - use @synthesize, @dynamic or provide a method implementation in this class implementation [-Werror,-Wobjc-property-implementation]

https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20%2832-bit%20Build%29/builds/7249
Comment 9 Alex Christensen 2016-06-27 17:43:27 PDT 
Comment on attachment 282176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282176&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2252
> +        if ([session respondsToSelector:@selector(hasSingleSecurityOrigin)])
> +            return session.hasSingleSecurityOrigin;

El Capitan compilers didn't like this.  Does it need to be [session hasSingleSecurityOrigin]?
Comment 10 Jer Noble 2016-06-27 23:35:22 PDT 
(In reply to comment #9)
> Comment on attachment 282176 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282176&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2252
> > +        if ([session respondsToSelector:@selector(hasSingleSecurityOrigin)])
> > +            return session.hasSingleSecurityOrigin;
> 
> El Capitan compilers didn't like this.  Does it need to be [session
> hasSingleSecurityOrigin]?

No, the error message is correct. It needs a @synthesize.
Comment 11 Jer Noble 2016-06-27 23:44:26 PDT 
Committed r202546: <http://trac.webkit.org/changeset/202546>