Bug 159170 - Clean up resetting reachability in B3/Air
Summary: Clean up resetting reachability in B3/Air
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2016-06-27 14:47 PDT by Filip Pizlo
Modified: 2016-06-27 15:27 PDT (History)
5 users (show)

See Also:

the patch (6.28 KB, patch)
2016-06-27 15:02 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-06-27 14:47:06 PDT
In r202512 I fixed a bug in B3::Procedure::resetReachability(), but this fix was more complicated than need be.  There was one set of data structures for the set of live basic blocks, and another for the set of live values - even though the set of blocks determined the set of values.
Comment 1 Filip Pizlo 2016-06-27 15:02:29 PDT
Created attachment 282171 [details]
the patch
Comment 2 Geoffrey Garen 2016-06-27 15:12:08 PDT
Comment on attachment 282171 [details]
the patch

Comment 3 Filip Pizlo 2016-06-27 15:27:13 PDT
Landed in https://trac.webkit.org/changeset/202518