Bug 159163 - Signal that media element is prepared for inline when being stopped since script won't be able to.
Summary: Signal that media element is prepared for inline when being stopped since scr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Macintosh Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-27 13:01 PDT by Jeremy Jones
Modified: 2016-07-06 13:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.81 KB, patch)
2016-06-27 13:07 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (3.43 KB, patch)
2016-07-06 11:20 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2016-06-27 13:01:16 PDT
Signal that media element is prepared for inline when being stopped since script won't be able to.
Comment 1 Jeremy Jones 2016-06-27 13:01:55 PDT
rdar://problem/26844557
Comment 2 Jeremy Jones 2016-06-27 13:07:10 PDT
Created attachment 282158 [details]
Patch
Comment 3 Eric Carlson 2016-06-27 13:27:39 PDT
Comment on attachment 282158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282158&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5058
> +    setPreparedForInline(true);

It would be slightly more efficient to add "if (m_preparedForInline)"
Comment 4 Jeremy Jones 2016-07-06 11:20:40 PDT
Created attachment 282912 [details]
Patch
Comment 5 WebKit Commit Bot 2016-07-06 13:02:47 PDT
Comment on attachment 282912 [details]
Patch

Clearing flags on attachment: 282912

Committed r202871: <http://trac.webkit.org/changeset/202871>
Comment 6 WebKit Commit Bot 2016-07-06 13:02:50 PDT
All reviewed patches have been landed.  Closing bug.