Bug 15915 - add an evaluation path for booleans like the one we have for numbers
Summary: add an evaluation path for booleans like the one we have for numbers
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P3 Enhancement
Assignee: Darin Adler
Depends on:
Reported: 2007-11-08 22:42 PST by Darin Adler
Modified: 2007-11-11 10:59 PST (History)
0 users

See Also:

patch (49.43 KB, patch)
2007-11-08 22:57 PST, Darin Adler
no flags Details | Formatted Diff | Diff
improved patch (54.73 KB, patch)
2007-11-09 08:48 PST, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-11-08 22:42:48 PST
There are a lot of boolean expressions and the profile shows time being spent in jsBoolean
Comment 1 Darin Adler 2007-11-08 22:57:43 PST
Created attachment 17139 [details]
Comment 2 Darin Adler 2007-11-09 08:48:02 PST
Created attachment 17157 [details]
improved patch
Comment 3 Sam Weinig 2007-11-09 16:27:29 PST
Comment on attachment 17157 [details]
improved patch

My only comment would be that you might want to check if jsBoolean(true) and jsBoolean(false) compile down to a constant.  Otherwise, r=me.
Comment 4 Darin Adler 2007-11-10 10:33:43 PST
Committed revision 27664.