Bug 159149 - Remove didFailAccessControlCheck ThreadableLoaderClient callback
Summary: Remove didFailAccessControlCheck ThreadableLoaderClient callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 151937
  Show dependency tree / graph
 
Reported: 2016-06-27 07:41 PDT by youenn fablet
Modified: 2020-11-02 13:57 PST (History)
8 users (show)

See Also:

Attachments
Patch (15.65 KB, patch)
2016-06-27 07:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (775.31 KB, application/zip)
2016-06-27 08:52 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (582.59 KB, application/zip)
2016-06-27 08:57 PDT, Build Bot 		no flags Details
Rebasing xhr test (19.06 KB, patch)
2016-06-27 09:50 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-06-27 07:41:04 PDT 
Following on bug 159085, we should remove didFailAccessControlCheck and use didFail instead.
Comment 1 youenn fablet 2016-06-27 07:58:53 PDT 
Created attachment 282132 [details]
Patch
Comment 2 youenn fablet 2016-06-27 08:07:36 PDT 
As a side note, it is not clear whether error messages should end with a '.'or not.
Consistency would be good here.
Comment 3 Build Bot 2016-06-27 08:51:57 PDT 
Comment on attachment 282132 [details]
Patch

Attachment 282132 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1580083

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm
Comment 4 Build Bot 2016-06-27 08:52:01 PDT 
Created attachment 282134 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-06-27 08:57:53 PDT 
Comment on attachment 282132 [details]
Patch

Attachment 282132 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1580084

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm
Comment 6 Build Bot 2016-06-27 08:57:56 PDT 
Created attachment 282135 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 7 youenn fablet 2016-06-27 09:50:01 PDT 
Created attachment 282139 [details]
Rebasing xhr test
Comment 8 WebKit Commit Bot 2016-06-27 23:09:25 PDT 
Comment on attachment 282139 [details]
Rebasing xhr test

Clearing flags on attachment: 282139

Committed r202542: <http://trac.webkit.org/changeset/202542>
Comment 9 WebKit Commit Bot 2016-06-27 23:09:30 PDT 
All reviewed patches have been landed.  Closing bug.