Now that we have merged many of the renderer classes, we can do the same for the creation in MathMLInlineContainerElement::createElementRenderer: if (hasTagName(annotation_xmlTag)) return createRenderer<RenderMathMLRow>(*this, WTFMove(style)); if (hasTagName(merrorTag) || hasTagName(mphantomTag) || hasTagName(mrowTag) || hasTagName(mstyleTag)) return createRenderer<RenderMathMLRow>(*this, WTFMove(style)); if (hasTagName(msubTag)) return createRenderer<RenderMathMLScripts>(*this, WTFMove(style)); if (hasTagName(msupTag)) return createRenderer<RenderMathMLScripts>(*this, WTFMove(style)); if (hasTagName(msubsupTag)) return createRenderer<RenderMathMLScripts>(*this, WTFMove(style)); if (hasTagName(mmultiscriptsTag)) return createRenderer<RenderMathMLScripts>(*this, WTFMove(style)); if (hasTagName(moverTag)) return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style)); if (hasTagName(munderTag)) return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style)); if (hasTagName(munderoverTag)) return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style));
Created attachment 282103 [details] Patch
Comment on attachment 282103 [details] Patch Yes -- simplify! r=me.
Comment on attachment 282103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282103&action=review > Source/WebCore/mathml/MathMLInlineContainerElement.cpp:68 > + if (hasTagName(annotation_xmlTag) || hasTagName(merrorTag) || hasTagName(mphantomTag) || hasTagName(mrowTag) || hasTagName(mstyleTag)) It seems like we should have a templated predicate "hasOneOfTheseTagNames(....)" someday.
Committed r202488: <http://trac.webkit.org/changeset/202488>