Bug 159111 – [macOS] Test gardening: Generic font families should not map to fonts which aren't installed

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[macOS] Generic font families should not map to fonts which aren't installed

[Myles C. Maxfield]

Created attachment 282041 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/25807529>

[Build Bot]

Comment on attachment 282041 [details]
Patch

Attachment 282041 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1565422

New failing tests:
svg/as-image/svg-image-with-data-uri-background.html

[Build Bot]

Created attachment 282044 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282041 [details]
Patch

Attachment 282041 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1565546

New failing tests:
svg/as-image/svg-image-with-data-uri-background.html

[Build Bot]

Created attachment 282045 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282041 [details]
Patch

Attachment 282041 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1565527

New failing tests:
svg/as-image/svg-image-with-data-uri-background.html

[Build Bot]

Created attachment 282046 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Myles C. Maxfield]

Created attachment 282196 [details]
Patch

[Myles C. Maxfield]

Created attachment 282206 [details]
Patch

[Myles C. Maxfield]

Committed r202538: <http://trac.webkit.org/changeset/202538>

[Brent Fulgham]

Comment on attachment 282196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282196&action=review

Typo!

> Source/WebCore/page/cocoa/SettingsCocoa.mm:62
> +    Retainptr<CFSetRef> mandatoryAttributes = adoptCF(CFSetCreate(kCFAllocatorDefault, keys, WTF_ARRAY_LENGTH(keys), &kCFTypeSetCallBacks));

RetainPtr!

[Brent Fulgham]

Comment on attachment 282196 [details]
Patch

This patch looks fine, but I'm worried it actually wasn't build or tested. R- to fix the typo and make sure EWS is happy.