Bug 159110 – REGRESSION: Web Inspector: Text search broken in resources with <CR>

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Text search broken in resources with <CR>.

Steps To Reproduce:
1. Inspect <http://daringfireball.net>
2. Open main resource (daringfireball.net) in Resources tab
3. Click in the editor
4. ⌘F to show find banner
5. Search for "href" or "title="
  => few results, all broken after the first <CR>

Notes:
- We changed CodeMirror to only \n as lineEndings earlier. The backend still treats \r as a line ending, which is causing slow drifting in line number differences between the frontend and backend.


[Joseph Pecoraro]

<rdar://problem/27008485>

[Joseph Pecoraro]

Created attachment 282040 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 282040 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282040&action=review

r=me with comments

> Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp:-107
> -        size_t nextStart = text.findNextLineStart(start);

Does this still have other callers?

> Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp:108
> +        if (nextStart == notFound || nextStart == text.length()) {

Good catch, although wouldn't the last character be text.length() - 1?

[Joseph Pecoraro]

(In reply to comment #3)
> Comment on attachment 282040 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282040&action=review
> 
> r=me with comments
> 
> > Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp:-107
> > -        size_t nextStart = text.findNextLineStart(start);
> 
> Does this still have other callers?

Hmm, no it doesn't.

> > Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp:108
> > +        if (nextStart == notFound || nextStart == text.length()) {
> 
> Good catch, although wouldn't the last character be text.length() - 1?

Yes! Good catch.

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/202498>