Bug 159107 - MSE gets confused by in-band text tracks
Summary: MSE gets confused by in-band text tracks
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
Keywords: InRadar
Depends on:
Reported: 2016-06-24 16:41 PDT by Jer Noble
Modified: 2016-06-24 16:54 PDT (History)
1 user (show)

See Also:

Patch (2.53 KB, patch)
2016-06-24 16:46 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-06-24 16:41:13 PDT
MSE gets confused by in-band text tracks
Comment 1 Jer Noble 2016-06-24 16:41:47 PDT
Comment 2 Radar WebKit Bug Importer 2016-06-24 16:41:54 PDT
Comment 3 Jer Noble 2016-06-24 16:46:07 PDT
Created attachment 282032 [details]
Comment 4 Eric Carlson 2016-06-24 16:48:25 PDT
Comment on attachment 282032 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=282032&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:620
> +            // FIXME: Handle in-band text tracks.

This should reference a bug.

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:686
> +        // FIXME: We don't handle text tracks, and passing this sample up to SourceBuffer will just
> +        // confuse its state. Drop this sample until we can handle text tracks properly.

Comment 5 Jer Noble 2016-06-24 16:54:42 PDT
Committed r202462: <http://trac.webkit.org/changeset/202462>