Bug 159094 – IDB tests crashing attempting to register sandbox extensions for blob files

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

IDB tests crashing attempting to register sandbox extensions for blob files

Especially seen in storage/indexeddb/modern/handle-user-delete.html (https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&showExpectations=true&revision=202420&tests=storage%2Findexeddb%2Fmodern%2Fhandle-user-delete.html)

Example:

Process:               com.apple.WebKit.WebContent.Development [18076]
Path:                  /Volumes/VOLUME/*/WebKit.framework/Versions/A/XPCServices/com.apple.WebKit.WebContent.Development.xpc/Contents/MacOS/com.apple.WebKit.WebContent.Development
Identifier:            com.apple.WebKit.WebContent.Development
Version:               602+ (602.1.36+)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           com.apple.WebKit.WebContent.Development [18076]
User ID:               501

Date/Time:             2016-06-24 08:20:44.806 -0700
OS Version:            Mac OS X 10.10.5 (14F1808)
Report Version:        11
Anonymous UUID:        001A66D5-6B78-D628-6709-95BDBC177AC5


Time Awake Since Boot: 2000000 seconds

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x00000000bbadbeef

VM Regions Near 0xbbadbeef:
--> 
    __TEXT                 000000010913b000-0000000109140000 [   20K] r-x/rwx SM=COW  /Volumes/VOLUME/*/WebKit.framework/Versions/A/XPCServices/com.apple.WebKit.WebContent.Development.xpc/Contents/MacOS/com.apple.WebKit.WebContent.Development

Application Specific Information:
CRASHING TEST: storage/indexeddb/modern/handle-user-delete.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x000000010d706e97 WTFCrash + 39
1   com.apple.WebCore             	0x000000011080fab7 WebCore::IDBResultData::getResult() const + 103
2   com.apple.WebKit              	0x00000001097f5a1d WebKit::preregisterSandboxExtensionsIfNecessary(WebKit::WebIDBResult const&) + 29
3   com.apple.WebKit              	0x00000001097f59c1 WebKit::WebIDBConnectionToServer::didGetRecord(WebKit::WebIDBResult const&) + 33
4   com.apple.WebKit              	0x000000010980a23f void IPC::callMemberFunctionImpl<WebKit::WebIDBConnectionToServer, void (WebKit::WebIDBConnectionToServer::*)(WebKit::WebIDBResult const&), std::__1::tuple<WebKit::WebIDBResult>, 0ul>(WebKit::WebIDBConnectionToServer*, void (WebKit::WebIDBConnectionToServer::*)(WebKit::WebIDBResult const&), std::__1::tuple<WebKit::WebIDBResult>&&, std::__1::integer_sequence<unsigned long, 0ul>) + 159
5   com.apple.WebKit              	0x0000000109809ff8 void IPC::callMemberFunction<WebKit::WebIDBConnectionToServer, void (WebKit::WebIDBConnectionToServer::*)(WebKit::WebIDBResult const&), std::__1::tuple<WebKit::WebIDBResult>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebKit::WebIDBResult>&&, WebKit::WebIDBConnectionToServer*, void (WebKit::WebIDBConnectionToServer::*)(WebKit::WebIDBResult const&)) + 88
6   com.apple.WebKit              	0x0000000109807748 void IPC::handleMessage<Messages::WebIDBConnectionToServer::DidGetRecord, WebKit::WebIDBConnectionToServer, void (WebKit::WebIDBConnectionToServer::*)(WebKit::WebIDBResult const&)>(IPC::MessageDecoder&, WebKit::WebIDBConnectionToServer*, void (WebKit::WebIDBConnectionToServer::*)(WebKit::WebIDBResult const&)) + 264
7   com.apple.WebKit              	0x0000000109806550 WebKit::WebIDBConnectionToServer::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 1440
8   com.apple.WebKit              	0x0000000109b21974 WebKit::WebToDatabaseProcessConnection::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 292
9   com.apple.WebKit              	0x000000010921a353 IPC::Connection::dispatchMessage(IPC::MessageDecoder&) + 51
10  com.apple.WebKit              	0x0000000109211524 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 724
11  com.apple.WebKit              	0x000000010921a94f IPC::Connection::dispatchOneMessage() + 1519
12  com.apple.WebKit              	0x000000010921f38d IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10::operator()() + 29
13  com.apple.WebKit              	0x000000010921f2dc WTF::NoncopyableFunction<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >)::$_10>::call() + 28
14  com.apple.JavaScriptCore      	0x000000010d736763 WTF::NoncopyableFunction<void ()>::operator()() const + 99
15  com.apple.JavaScriptCore      	0x000000010d751ef8 WTF::RunLoop::performWork() + 440
16  com.apple.JavaScriptCore      	0x000000010d7525c4 WTF::RunLoop::performWork(void*) + 36
17  com.apple.CoreFoundation      	0x00007fff8b571a01 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
18  com.apple.CoreFoundation      	0x00007fff8b563b8d __CFRunLoopDoSources0 + 269
19  com.apple.CoreFoundation      	0x00007fff8b5631bf __CFRunLoopRun + 927
20  com.apple.CoreFoundation      	0x00007fff8b562bd8 CFRunLoopRunSpecific + 296
21  com.apple.HIToolbox           	0x00007fff86fc956f RunCurrentEventLoopInMode + 235
22  com.apple.HIToolbox           	0x00007fff86fc92ea ReceiveNextEventCommon + 431
23  com.apple.HIToolbox           	0x00007fff86fc912b _BlockUntilNextEventMatchingListInModeWithFilter + 71
24  com.apple.AppKit              	0x00007fff888608ab _DPSNextEvent + 978
25  com.apple.AppKit              	0x00007fff8885fe58 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 346
26  com.apple.AppKit              	0x00007fff88855af3 -[NSApplication run] + 594
27  com.apple.AppKit              	0x00007fff887d2244 NSApplicationMain + 1832
28  libxpc.dylib                  	0x00007fff9314b928 _xpc_objc_main + 793
29  libxpc.dylib                  	0x00007fff9314d030 xpc_main + 490
30  com.apple.WebKit.WebContent.Development	0x000000010913c7a0 main + 800
31  libdyld.dylib                 	0x00007fff931665c9 start + 1

[Brady Eidson]

Created attachment 281993 [details]
Patch

[Sam Weinig]

Comment on attachment 281993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281993&action=review

> Source/WebKit2/ChangeLog:7
> +

Please mention this is already tested and by what.

[Brady Eidson]

http://trac.webkit.org/changeset/202424