REGRESSION(r201171): CRASH at WebKit::WebInspectorProxy::open() + 31 when running inspector layout tests

[BJ Burg]

Looks like something weird is going on.

[BJ Burg]

<rdar://problem/26768628>

[BJ Burg]

Created attachment 281931 [details]
Proposed Fix

[Joseph Pecoraro]

Comment on attachment 281931 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281931&action=review

r=me

> Source/WebKit2/ChangeLog:12
> +        However, it doesn't make sense that we would hit the null dereference here:

Should we add an ASSERT?

[BJ Burg]

Comment on attachment 281931 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281931&action=review

>> Source/WebKit2/ChangeLog:12
>> +        However, it doesn't make sense that we would hit the null dereference here:
> 
> Should we add an ASSERT?

I added a more valuable assert in https://bugs.webkit.org/show_bug.cgi?id=159073. Since this code is only ever called via IPC (one frame below bringToFront()) an assertion here is not going to tell us anything useful, as the backtrace will just be full of IPC junk.

[WebKit Commit Bot]

Comment on attachment 281931 [details]
Proposed Fix

Clearing flags on attachment: 281931

Committed r202464: <http://trac.webkit.org/changeset/202464>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.